Add concat() to original array to stay immutable

BeaverHouse · Dec 17, 2024 · e867d12 · e867d12
1 parent 11784ac
commit e867d12
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/src/components/organisms/analysis/LegacyAnalysis.tsx b/src/components/organisms/analysis/LegacyAnalysis.tsx
@@ -29,6 +29,7 @@ const LegacyAnalysis: React.FC<AnalysisProps> = ({ allCharacters }) => {
   const { t } = useTranslation();
 
   const baseCharacters = allCharacters
+    .concat()
     .filter((char) => getNumber(char) < 1000)
     .sort((a, b) => a.id.localeCompare(b.id));
 

diff --git a/src/components/organisms/analysis/LegacyTableAnalysis.tsx b/src/components/organisms/analysis/LegacyTableAnalysis.tsx
@@ -12,11 +12,13 @@ import DownloadButton from "../../atoms/button/Download";
 const LegacyTableAnalysis: React.FC<AnalysisProps> = ({ allCharacters }) => {
   const { t, i18n } = useTranslation();
   const { setModal } = useModalStore();
-  const baseCharacters = allCharacters.sort((a, b) =>
-    getShortName(t(a.code), i18n.language).localeCompare(
-      getShortName(t(b.code), i18n.language)
-    )
-  );
+  const baseCharacters = allCharacters
+    .concat()
+    .sort((a, b) =>
+      getShortName(t(a.code), i18n.language).localeCompare(
+        getShortName(t(b.code), i18n.language)
+      )
+    );
 
   return (
     <>

diff --git a/src/components/organisms/analysis/StardreamAnalysis.tsx b/src/components/organisms/analysis/StardreamAnalysis.tsx
@@ -32,13 +32,14 @@ const StardreamAnalysis: React.FC<AnalysisProps> = ({ allCharacters }) => {
   const { t, i18n } = useTranslation();
 
   const baseCharacters = allCharacters
+    .concat()
     .filter(
       (char, idx) =>
         char.category === AECategories.encounter &&
         char.style !== AECharacterStyles.four &&
         (!ShowRecentStyles ||
           !allCharacters
-            .slice(idx+1)
+            .slice(idx + 1)
             .map((c) => c.code)
             .includes(char.code)) &&
         (!ShowSevenPiece ||

diff --git a/src/components/organisms/analysis/WhiteKeyAnalysis.tsx b/src/components/organisms/analysis/WhiteKeyAnalysis.tsx
@@ -31,6 +31,7 @@ const WhiteKeyAnalysis: React.FC<AnalysisProps> = ({ allCharacters }) => {
   const { t, i18n } = useTranslation();
 
   const baseCharacters = allCharacters
+    .concat()
     .filter(
       (char) =>
         char.category === AECategories.encounter &&