Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pandas.testing.assert_frame_equal #250

Merged
merged 2 commits into from
Sep 14, 2023
Merged

use pandas.testing.assert_frame_equal #250

merged 2 commits into from
Sep 14, 2023

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Sep 5, 2023

@orbeckst
Copy link
Member Author

orbeckst commented Sep 5, 2023

Two tests fail locally

================================== short test summary info ===================================
FAILED tests/fileformats/top/test_amber03star.py::TestAmber03star::test_mdrun - KeyError: "['Improper Dih.'] not in index"
FAILED tests/fileformats/top/test_amber03w.py::TestAmber03w::test_mdrun - KeyError: "['Improper Dih.'] not in index"
========================= 2 failed, 16 passed, 2 warnings in 17.92s ==========================

Not sure why, need to look into it... maybe newer version of GROMACS??

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #250 (c408802) into main (11f0daf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   66.49%   66.49%           
=======================================
  Files          23       23           
  Lines        4325     4325           
  Branches      748      739    -9     
=======================================
  Hits         2876     2876           
- Misses       1254     1256    +2     
+ Partials      195      193    -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@orbeckst
Copy link
Member Author

orbeckst commented Sep 5, 2023

This is actually #236 — although it ought to have been skipped?!?

@orbeckst
Copy link
Member Author

Failures are an issue with mamba on macOS, which I am going to ignore.

@orbeckst orbeckst merged commit 05c3625 into main Sep 14, 2023
15 of 17 checks passed
@orbeckst orbeckst deleted the update-pandas-testing branch September 14, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant