Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible residue names for OPLS ions #85

Open
iorga opened this issue Mar 13, 2017 · 6 comments
Open

incompatible residue names for OPLS ions #85

iorga opened this issue Mar 13, 2017 · 6 comments
Assignees
Milestone

Comments

@iorga
Copy link
Collaborator

iorga commented Mar 13, 2017

I tried to set up a simulation using a positively charged ligand (with Gromacs 4.6) and I've got the following error.

gromacs.setup: INFO     Solvated system with tip4p.gro
gromacs.cbook: INFO     system total charge qtot = 1.0
gromacs.setup: INFO     [/lig-plus/Equilibrium/water/solvation] After solvation: total charge qtot = 1.0 = 1.0
gromacs.setup: INFO     [/lig-plus/Equilibrium/water/solvation] Adding n_cation = 0 and n_anion = 1 ions...
/sge/packs_centos/opt/python-2.7.10-CentOS6/lib/python2.7/site-packages/gromacs/core.py:551: GromacsFailureWarning: Gromacs tool failed
Command invocation: grompp -p /lig-plus/Equilibrium/water/top/system.top -c ionized.gro -maxwarn 1 -o ionized.tpr -f none.mdp
Gromacs command 'grompp' fatal error message:
GMX_FATAL  Source code file: /tmp/gromacs-4.6/src/kernel/toppush.c, line: 2316
GMX_FATAL 
GMX_FATAL  Fatal error:
GMX_FATAL  No such moleculetype CL
GMX_FATAL  For more information and tips for troubleshooting, please check the GROMACS
GMX_FATAL  website at http://www.gromacs.org/Documentation/Errors
Error code: 255

It seems that all recent versions of Gromacs (>= 4.5) have residue names in oplsaa.ff/ions.itp without the charge included (e.g. NA or BR), whereas in our ions_opls.itp that is included in the topology files these residue names contain explicitly the charge (e.g. NA+ or BR-).

I would suggest to update the residue names to make them compatible with the recent versions of Gromacs.

@iorga iorga added the bug label Mar 13, 2017
@orbeckst
Copy link
Member

Ok, yes, ... did we really start in the 4.5 days???

@orbeckst
Copy link
Member

Do you have time to fix the FF file?

@orbeckst orbeckst added this to the 0.7 milestone Apr 12, 2019
@orbeckst orbeckst modified the milestones: 0.7, 1.0 Jul 23, 2021
@orbeckst
Copy link
Member

Moved to later milestone... we survived with this bug for the last 4 years so fixing it cannot be that urgent.

@iorga
Copy link
Collaborator Author

iorga commented Jul 23, 2021

@orbeckst Given that we generally use MDPOW for simulating neutral compounds, this problem should not matter. But we have never said explicitely that MDPOW handles only neutral compounds, so in the end this issue needs to be fixed at some point.

@orbeckst
Copy link
Member

The way I see it, as soon as we document it, we don't have to implement it. I'd rather look at it the opposite way than you: we never promised that it would work so this issue here is an enhancement suggestion and not a bug. Maybe I can squeeze a doc edit into PR #167 .

@orbeckst
Copy link
Member

But yes, we should fix the ion names.

That also means that someone needs to write a test for it etc.

We leave the issue open but it’s low priority for me. If anyone sees this as a pressing problem please comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants