Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use relative imports inside MDPOW #257

Merged
merged 2 commits into from
Jul 2, 2023
Merged

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Jul 2, 2023

- fix #245
- avoid circular imports involving the workflows.registry
@orbeckst
Copy link
Member Author

orbeckst commented Jul 2, 2023

@cadeduckworth have a look at this PR. These relative imports work, at least in local testing. If this looks good to you, approve and merge.

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #257 (7ce55c4) into develop (afb1ced) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #257      +/-   ##
===========================================
- Coverage    80.74%   80.73%   -0.02%     
===========================================
  Files           15       15              
  Lines         1906     1905       -1     
  Branches       294      294              
===========================================
- Hits          1539     1538       -1     
  Misses         276      276              
  Partials        91       91              
Impacted Files Coverage Δ
mdpow/workflows/base.py 81.63% <100.00%> (ø)
mdpow/workflows/dihedrals.py 94.87% <100.00%> (-0.05%) ⬇️
mdpow/workflows/registry.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@cadeduckworth cadeduckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orbeckst

Looks good, thank you for catching this!

I noticed things of this nature here and there while reviewing and finishing up #243, probably from early stages of development. Once #243 is merged and we start working on #244 I think that will result in a complete cleanup of the entire workflows module and related test modules.

Reminder, when time allows, there are still issues that exist that require revisiting the analysis modules and tests for revisions mostly required by software package updates (i.e., pytest).

@cadeduckworth cadeduckworth merged commit 4de96a4 into develop Jul 2, 2023
@cadeduckworth cadeduckworth deleted the use-relative-import branch July 2, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix import error in workflows base module (develop branch)
2 participants