-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvments Local adjustments - Color Appearance Cam 16 and Log encoding #6678
Conversation
rtdata/languages/default
Outdated
@@ -2815,7 +2815,8 @@ TP_LOCALLAB_BUTTON_DUPL;Duplicate | |||
TP_LOCALLAB_BUTTON_REN;Rename | |||
TP_LOCALLAB_BUTTON_VIS;Show/Hide | |||
TP_LOCALLAB_BWEVNONE;None | |||
TP_LOCALLAB_BWEVSIG;Sigmoid only | |||
//TP_LOCALLAB_BWEVSIG;Sigmoid only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entries should be deleted, not commented out.
@@ -2815,7 +2815,8 @@ TP_LOCALLAB_BUTTON_DUPL;Duplicate | |||
TP_LOCALLAB_BUTTON_REN;Rename | |||
TP_LOCALLAB_BUTTON_VIS;Show/Hide | |||
TP_LOCALLAB_BWEVNONE;None | |||
TP_LOCALLAB_BWEVSIG;Sigmoid only | |||
//TP_LOCALLAB_BWEVSIG;Sigmoid only | |||
TP_LOCALLAB_BWEVSIG;Activated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use GENERAL_ENABLED instead of creating a new key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Beep6581
OK for delete instead of commented out.
For the new key, I want to keep the possibility of a third choice (possible in locallabtools2)
Jacques
Hello, and excuse my bad english.
This PR aims at both, simplification and performance improvement of " Local adjustments ", " Color appearance - Cam16 ".
Branch "lacam16"
These improvements affect the GUI - which is still to be improved (because it is complex due to the mix of Cam16, Jz codes and the possibility of Zcam).
But obviously the main improvements concern the algorithms. As a reminder on the vocabulary and some principles (use of log), they are close to " Filmic ", " Sigmoid ", " New colorimetry " in Darktable. On the substance, the principles (use of Lab, Cam, Brightness, etc.), they are different.
I also enriched the "masks" part.
For more information see issue #6653.
To summarize you can now:
I don't give by principle, any name to make a review, whether it is "code" or "algorithms", free to each one to express himself.
One can also tell me that :
I have also update rawpedia (in french)
https://rawpedia.rawtherapee.com/Local_Adjustments/fr#Utilisation_de_Cam16_et_des_fonctionnalit%C3%A9s_HDR
jacques