Skip to content

Commit

Permalink
update dev packages; add README for Isensee; remove default values fr…
Browse files Browse the repository at this point in the history
…om model selection parameters in SBML
  • Loading branch information
dilpath committed Nov 8, 2024
1 parent e4e8325 commit 1645810
Show file tree
Hide file tree
Showing 4 changed files with 46 additions and 25 deletions.
17 changes: 17 additions & 0 deletions Benchmark-Models/Isensee_JCB2018/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
The paper describes a model selection problem with four hypotheses. Each hypothesis involves adding a set of parameters to the model -- these sets of parameters are annotated in the `model_selection_group` column of the parameters table. The paper shows a result where the model with the first hypothesis alone (H1) was accepted as the best by AIC.

This benchmark problem is the parameter estimation problem for the H1-only model. The parameters for the other hypotheses are specified in `parameters_Isensee_JCB2018_model_selection.tsv`. For example, this Python code will create the PEtab problem for the H2+H3 model.
```python
import pandas as pd
import petab

petab_problem = petab.Problem.from_yaml("Isensee_JCB2018.yaml")
model_selection_parameter_df = petab.get_parameter_df("parameters_Isensee_JCB2018_model_selection.tsv")

petab_problem.parameter_df = petab.get_parameter_df(pd.concat([
# Remove the H1 parameters
petab_problem.parameter_df.query("model_selection_group != 'H1: different KD'"),
# Add the H2 and H3 parameters
model_selection_parameter_df.query("model_selection_group in ['H2: AC inhibition', 'H3: incomplete import']")
]))
```
32 changes: 18 additions & 14 deletions Benchmark-Models/Isensee_JCB2018/model_Isensee_JCB2018.xml
Original file line number Diff line number Diff line change
Expand Up @@ -97,16 +97,13 @@
<parameter metaid="KD_Fsk" id="KD_Fsk" value="14.2656743301721"/>
<parameter metaid="KD_H89" id="KD_H89" value="0.0480736009761681"/>
<parameter metaid="KD_IBMX" id="KD_IBMX" value="11.9768989891142"/>
<parameter metaid="KD_PDE_Csub" id="KD_PDE_Csub" value="0"/>
<parameter metaid="KD_cAMP" id="KD_cAMP" value="2.84986906175302"/>
<parameter metaid="PDE_total" id="PDE_total" value="1"/>
<parameter metaid="RII2_total" id="RII2_total" value="1"/>
<parameter metaid="kdeg_cAMP" id="kdeg_cAMP" value="1.00032978441703e-05"/>
<parameter metaid="kdeg_cAMP_free" id="kdeg_cAMP_free" value="7.35892283451732"/>
<parameter metaid="kdp_AC" id="kdp_AC" value="0"/>
<parameter metaid="kf_Fsk" id="kf_Fsk" value="999.991987450139"/>
<parameter metaid="kf_H89" id="kf_H89" value="0.000741493422675392"/>
<parameter metaid="kf_PDE_Csub" id="kf_PDE_Csub" value="0"/>
<parameter metaid="kf_RII_2__RII_C_2" id="kf_RII_2__RII_C_2" value="1.26077939273477"/>
<parameter metaid="kf_RII_C_2__RII_2" id="kf_RII_C_2__RII_2" value="0.0187262534054505"/>
<parameter metaid="kf_RII_C_2__RIIp_C_2" id="kf_RII_C_2__RIIp_C_2" value="0.0227841500487899"/>
Expand All @@ -119,25 +116,14 @@
<parameter metaid="ki_Rp8_pCPT_cAMPS_pAB" id="ki_Rp8_pCPT_cAMPS_pAB" value="9.24294887100985"/>
<parameter metaid="ki_Rp_cAMPS_pAB" id="ki_Rp_cAMPS_pAB" value="0.0163472838984393"/>
<parameter metaid="ki_Sp8_Br_cAMPS_AM" id="ki_Sp8_Br_cAMPS_AM" value="0.131083036712545"/>
<parameter metaid="kp_AC" id="kp_AC" value="0"/>
<parameter metaid="ks_AC_cAMP" id="ks_AC_cAMP" value="0.423299046028554"/>
<parameter metaid="xi_AC_cAMP_Fsk" id="xi_AC_cAMP_Fsk" value="640.551657640036"/>
<parameter metaid="xi_KD_Rp8_Br_cAMPS" id="xi_KD_Rp8_Br_cAMPS" value="0.040150612333366"/>
<parameter metaid="xi_KD_Rp8_pCPT_cAMPS" id="xi_KD_Rp8_pCPT_cAMPS" value="0.194630402579553"/>
<parameter metaid="xi_KD_Rp_cAMPS" id="xi_KD_Rp_cAMPS" value="0.163369645426461"/>
<parameter metaid="xi_KD_Sp8_Br_cAMPS" id="xi_KD_Sp8_Br_cAMPS" value="0.222276461349335"/>
<parameter metaid="xi_b_Rp8_Br_cAMPS" id="xi_b_Rp8_Br_cAMPS" value="0.0408695544562406"/>
<parameter metaid="xi_b_Rp8_pCPT_cAMPS" id="xi_b_Rp8_pCPT_cAMPS" value="0.0268897774883765"/>
<parameter metaid="xi_b_Rp_cAMPS" id="xi_b_Rp_cAMPS" value="0.607960299288444"/>
<parameter metaid="xi_b_Sp8_Br_cAMPS" id="xi_b_Sp8_Br_cAMPS" value="21.7551956731725"/>
<parameter metaid="xi_i_Rp8_Br_cAMPS_pAB" id="xi_i_Rp8_Br_cAMPS_pAB" value="1"/>
<parameter metaid="xi_i_Rp8_pCPT_cAMPS_pAB" id="xi_i_Rp8_pCPT_cAMPS_pAB" value="1"/>
<parameter metaid="xi_i_Rp_cAMPS_pAB" id="xi_i_Rp_cAMPS_pAB" value="1"/>
<parameter metaid="xi_i_Sp8_Br_cAMPS_AM" id="xi_i_Sp8_Br_cAMPS_AM" value="1"/>
<parameter metaid="xi_kf_RII_2__RII_C_2" id="xi_kf_RII_2__RII_C_2" value="0.0189295042137343"/>
<parameter metaid="xi_kf_RII_C_2__RII_2" id="xi_kf_RII_C_2__RII_2" value="0.811223214879921"/>
<parameter metaid="xi_pAC" id="xi_pAC" value="1"/>
<parameter metaid="xi_pPDE" id="xi_pPDE" value="1"/>
<parameter metaid="Fsk" id="Fsk" value="10" units="time" constant="false"/>
<parameter metaid="IBMXex" id="IBMXex" value="0" constant="false"/>
<parameter metaid="H89" id="H89" value="0" constant="false"/>
Expand All @@ -162,6 +148,24 @@
<parameter metaid="Sp8_Br_cAMPS_AM_time" id="Sp8_Br_cAMPS_AM_time" value="0" units="time"/>
<parameter metaid="fourABnOH_level" id="fourABnOH_level" value="0" units="substance"/>
<parameter metaid="fourABnOH_time" id="fourABnOH_incubation_time" value="0" units="time"/>
<!-- H1: different KD -->
<parameter metaid="xi_KD_Rp8_Br_cAMPS" id="xi_KD_Rp8_Br_cAMPS" value="0"/>
<parameter metaid="xi_KD_Rp8_pCPT_cAMPS" id="xi_KD_Rp8_pCPT_cAMPS" value="0"/>
<parameter metaid="xi_KD_Rp_cAMPS" id="xi_KD_Rp_cAMPS" value="0"/>
<parameter metaid="xi_KD_Sp8_Br_cAMPS" id="xi_KD_Sp8_Br_cAMPS" value="0"/>
<!-- H2: AC inhibition -->
<parameter metaid="xi_pAC" id="xi_pAC" value="0"/>
<parameter metaid="kp_AC" id="kp_AC" value="0"/>
<parameter metaid="kdp_AC" id="kdp_AC" value="0"/>
<!-- H3: incomplete import -->
<parameter metaid="xi_i_Rp8_Br_cAMPS_pAB" id="xi_i_Rp8_Br_cAMPS_pAB" value="0"/>
<parameter metaid="xi_i_Rp8_pCPT_cAMPS_pAB" id="xi_i_Rp8_pCPT_cAMPS_pAB" value="0"/>
<parameter metaid="xi_i_Rp_cAMPS_pAB" id="xi_i_Rp_cAMPS_pAB" value="0"/>
<parameter metaid="xi_i_Sp8_Br_cAMPS_AM" id="xi_i_Sp8_Br_cAMPS_AM" value="0"/>
<!-- H4: PDE inhibition -->
<parameter metaid="xi_pPDE" id="xi_pPDE" value="0"/>
<parameter metaid="kf_PDE_Csub" id="kf_PDE_Csub" value="0"/>
<parameter metaid="KD_PDE_Csub" id="KD_PDE_Csub" value="0"/>
</listOfParameters>
<listOfRules>
<assignmentRule metaid="CDMT00167" variable="Fsk">
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
parameterId parameterName parameterScale lowerBound upperBound nominalValue estimate objectivePriorType objectivePriorParameters model_selection_group
xi_pAC \xi_{pAC} log10 0.001 1 1 0 parameterScaleNormal 0;3 H2: AC inhibition
kp_AC kp_{AC} log10 1E-5 1E3 0 0 H2: AC inhibition
kdp_AC kdp_{AC} log10 1E-5 1E3 0 0 H2: AC inhibition
xi_i_Rp8_Br_cAMPS_pAB \xi_{i,Rp8,Br,cAMPS,pAB} log10 1E-05 1 1 0 parameterScaleNormal 0;3 H3: incomplete import
xi_i_Rp8_pCPT_cAMPS_pAB \xi_{i,Rp8,pCPT,cAMPS,pAB} log10 1E-05 1 1 0 parameterScaleNormal 0;3 H3: incomplete import
xi_i_Rp_cAMPS_pAB \xi_{i,Rp,cAMPS,pAB} log10 1E-05 1 1 0 parameterScaleNormal 0;3 H3: incomplete import
xi_i_Sp8_Br_cAMPS_AM \xi_{i,Sp8,Br,cAMPS,AM} log10 1E-05 1 1 0 parameterScaleNormal 0;3 H3: incomplete import
xi_pPDE \xi_{pPDE} log10 1 1000 1 0 parameterScaleNormal 0.397940008672038;3 H4: PDE_inhibition
kf_PDE_Csub kf_{PDE,Csub} log10 1E-5 1E3 0 0 H4: PDE_inhibition
KD_PDE_Csub KD_{PDE,Csub} log10 1E-5 1E3 0 0 H4: PDE_inhibition
xi_pAC \xi_{pAC} log10 0.001 1 1 1 parameterScaleNormal 0;3 H2: AC inhibition
kp_AC kp_{AC} log10 1E-5 1E3 0 1 H2: AC inhibition
kdp_AC kdp_{AC} log10 1E-5 1E3 0 1 H2: AC inhibition
xi_i_Rp8_Br_cAMPS_pAB \xi_{i,Rp8,Br,cAMPS,pAB} log10 1E-05 1 1 1 parameterScaleNormal 0;3 H3: incomplete import
xi_i_Rp8_pCPT_cAMPS_pAB \xi_{i,Rp8,pCPT,cAMPS,pAB} log10 1E-05 1 1 1 parameterScaleNormal 0;3 H3: incomplete import
xi_i_Rp_cAMPS_pAB \xi_{i,Rp,cAMPS,pAB} log10 1E-05 1 1 1 parameterScaleNormal 0;3 H3: incomplete import
xi_i_Sp8_Br_cAMPS_AM \xi_{i,Sp8,Br,cAMPS,AM} log10 1E-05 1 1 1 parameterScaleNormal 0;3 H3: incomplete import
xi_pPDE \xi_{pPDE} log10 1 1000 1 1 parameterScaleNormal 0.397940008672038;3 H4: PDE inhibition
kf_PDE_Csub kf_{PDE,Csub} log10 1E-5 1E3 0 1 H4: PDE inhibition
KD_PDE_Csub KD_{PDE,Csub} log10 1E-5 1E3 0 1 H4: PDE inhibition
2 changes: 1 addition & 1 deletion src/python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ dependencies = [
]

[project.optional-dependencies]
dev = ["ruff"]
dev = ["pre-commit", "pytest", "ruff"]

[project.scripts]
bmp-petablint = "benchmark_models_petab.check_petablint:main"
Expand Down

0 comments on commit 1645810

Please sign in to comment.