Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
  • Loading branch information
dweindl and dilpath authored Oct 15, 2024
1 parent 7e226e6 commit d2a4924
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/python/benchmark_models_petab/overview.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def get_summary(
petab_problem.parameter_df[petab.ESTIMATE]
),
"events": len(petab_problem.sbml_model.getListOfEvents()),
"discontinuities": has_discontinuities(petab_problem),
"possible discontinuities": guess_discontinuities(petab_problem),
"preequilibration": 0
if petab.PREEQUILIBRATION_CONDITION_ID
not in petab_problem.measurement_df.columns
Expand Down Expand Up @@ -171,7 +171,7 @@ def get_prior_distributions(parameter_df: pd.DataFrame) -> str:
return "; ".join(filter(None, unique))


def has_discontinuities(petab_problem: petab.Problem) -> bool:
def guess_discontinuities(petab_problem: petab.Problem) -> bool:
"""Guess whether the model has discontinuities.
Potential discontinuities in the model state or its derivative:
Expand Down

0 comments on commit d2a4924

Please sign in to comment.