-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the reformulated version of Fiedler_BMCSystBiol2016 #258
Conversation
would assume that all of the data is the same – why not just add separate model/parameters/yaml file to the base directory and reuse everything else? |
The data is the same, the observable Ids changed (e.g. I could rename the observables and associated parameters but I have a minor preference for keeping the new names to distinguish the interpretation of the observables in the old and reformulated model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Since this is similar to submitting a new problem, you could add the checklist to this PR and indicate what is done/not done (of course, not everything has to be done since this is not the "main" problem -- simply leave those unchecked as a matter of record).
Benchmark-Models/Fiedler_BMCSystBiol2016/measurementData_Fiedler_BMCSystBiol2016.tsv
Outdated
Show resolved
Hide resolved
Benchmark-Models/Fiedler_BMCSystBiol2016/reformulated/parameters_Fiedler_BMCSystBiol2016.tsv
Outdated
Show resolved
Hide resolved
Benchmark-Models/Fiedler_BMCSystBiol2016/reformulated/Fiedler_BMCSystBiol2016.yaml
Outdated
Show resolved
Hide resolved
Benchmark-Models/Fiedler_BMCSystBiol2016/reformulated/model_Fiedler_BMCSystBiol2016.xml
Outdated
Show resolved
Hide resolved
|
I think this is missing, but also fine to uncheck this box instead. |
Fiedler_BMCSystBiol2016
model, taken from the same publication, that removes non-identifiabilitiesdatasetId
column for the existingFiedler_BMCSystBiol2016
model