EDMG BNF #2732
EDMG BNF #2732
Conversation
DenisNosnitsin1970
requested review from
eu-genia,
nafisa-valieva and
CarstenHoffmannMarburg
EndaMaryamDengelat/EDMG045.xml
Outdated
| <material key="parchment"/> | ||
| </support> | ||
| <extent> | ||
| <measure unit="leaf" quantity="127">27</measure> |
There was a problem hiding this comment.
Number in quantity should match the number in the tag.
Is it by accident the same value as in DHAS024 above, or possibly a Copy&Paste error?
There was a problem hiding this comment.
Just a mistake.
EndaMaryamDengelat/EDMG045.xml
Outdated
| <textLang mainLang="gez"/> | ||
|
|
||
| <notatedMusic> | ||
| <desc>Musical notation in red and black thoughout the text.</desc> |
ParisBNF/abb/BNFabb57.xml
Outdated
| <incipit xml:lang="gez">ወዛካርያስ᎓ ወፈጸምያነ᎓ ትንቢት᎓ ከዊኖሙ᎓ ወዳንኤልሰ᎓ ወሕዝቅኤልሰ᎓ በፄዋዌ᎓ ተነበዩ᎓ በቢሎን᎓ | ||
| ወኮኑ᎓ ካህናተ᎓ ኵሎሙ᎓ <hi rend="rubric">፯፡</hi> | ||
| <explicit xml:lang="gez">ቀዳሚ፡ ኵሉ፡ ነግሠ፡ ሳኦል፡ ለእስራኤል፡ ዓመታት፡ ፵ዘእም፡ ነገደ፡ ብንያም፡ ወእምነገደ፡ ይሁዳ፨ ወእምድኅረዝ፡ ነግሠ፡ ዳዊት፡</explicit> | ||
| <incipit xml:lang="gez">ወዛካርያስ፡ ወፈጸምያነ፡ ትንቢት፡ ከዊኖሙ፡ ወዳንኤልሰ፡ ወሕዝቅኤልሰ፡ በፄዋዌ፡ ተነበዩ፡ በቢሎን፡ ወኮኑ፡ ካህናተ፡ ኵሎሙ፡ <hi rend="rubric">፯፡</hi> |
There was a problem hiding this comment.
Why did you place the incipit after the explicit? Will this be presented on the website in the same order or is the order always, that the incipit is placed before the explicit after it is transformed, as it should be?
EndaMaryamDengelat/EDMG045.xml
Outdated
| <msIdentifier> | ||
| <repository ref="INS1017EndaMaryamDengelat"/> | ||
| <idno>EDMG-045</idno> | ||
| <idno facs="EDMG/045/EDMG-045_" n="58">EDMG-045</idno> |
There was a problem hiding this comment.
I do not have these images I believe
There was a problem hiding this comment.
They are coming, need some processing.
EndaMaryamDengelat/EDMG045.xml
Outdated
| <msDesc xml:id="ms"> | ||
| <msIdentifier> | ||
| <repository ref="INS1017EndaMaryamDengelat"/> | ||
| <idno>EDMG-045</idno> |
There was a problem hiding this comment.
changed.
EndaMaryamDengelat/EDMG045.xml
Outdated
| <repository ref="INS1017EndaMaryamDengelat"/> | ||
| <idno>EDMG-045</idno> | ||
| <idno facs="EDMG/045/EDMG-045_" n="58">EDMG-045</idno> | ||
| </msIdentifier> |
There was a problem hiding this comment.
please also check EDMG001 EDMG002 etc that have multiple idno elements - there should only be one, all others should be in altIdentifier
There was a problem hiding this comment.
Changed.
EndaMaryamDengelat/EDMG045.xml
Outdated
| <textLang mainLang="gez"/> | ||
| <note>Only two thirds of the text leaf, originally belonging probably to | ||
| Ms <ref type="mss" corresp="DHAS023">Dabra Hāllelo ʾƎndā ʾAbuna Sāmuʾel DHAS-023</ref>.</note> | ||
| </msItem> |
There was a problem hiding this comment.
I think we need a relation to show this
There was a problem hiding this comment.
changed.
ParisBNF/et/BNFet336.xml
Outdated
| <collection>Manuscrits orientaux</collection> | ||
| <collection>Fonds éthiopien</collection> | ||
| <collection>Griaule</collection> | ||
| <idno>BnF Éthiopien 336 (Griaule 32)</idno> |
There was a problem hiding this comment.
<idno>BnF Éthiopien 336</idno>
<altIdentifier>
<idno>Griaule 32</idno>
</altIdentifier>
you do not need Griaule 32 twice
There was a problem hiding this comment.
Yes, this is true. Here I followed "the tradition", the <idno>BnF Éthiopien 336 (Griaule 32)</idno> was designed to be displayed as "BnF Éthiopien 336 " in the app, as other Griaule mss, with double shelf mark (thorough numeration and the numeration according to "the fond"). I think it has its reasons, and it is correct to display them both. If I place Griaule 32 in <altIdentifier/> only, it is now displayed in small letters on the right side, separate from the shelf mark, not very well visible. This is ok for me, but will bring some inconvinience for the user (usually Griaule mss are referred without BnF shelfmarks). Should I change it? (I can change also other Griaule records).
There was a problem hiding this comment.
We should always be very careful to keep encoding and visualization apart.
Each identifier and each shelfmark MUST be encoded separately.
If for some reason the visualization is not what you want then you need an issue for visualization. We can always have a different way to show altIdentifiers, or we can have separate rules for different types, this is all possible, but encoding has nothing to do with visualization.
Updates, corrections of shelfmarks.
Minor changes in mss, stub for Griaule 32.