Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create BLEthiopic3.xml #2761

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Create BLEthiopic3.xml #2761

merged 2 commits into from
Jan 8, 2025

Conversation

nafisa-valieva
Copy link
Contributor

I have created a stub to be able to refer to it as a witness used by Dillmann

Copy link
Contributor

@eu-genia eu-genia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. just two minor things. And you can realign the XML if you want the nesting to look nicer.

<listBibl type="secondary">
<bibl>
<ptr target="bm:DickhutEllwardt2018Dillmann"/>
<citedRange>83-84.</citedRange>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the dot after the pages

<idno>BL Indian Office Collection MS Ethiopic 3</idno>
</msIdentifier>
<msContents>
<msItem xml:id="ms_i1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case this is not so important if there is only one text, but as a rule it is recommended to always have an empty <summary/> after <msContents> so that the TOC of a ms is printed

@nafisa-valieva nafisa-valieva merged commit 8dad15f into master Jan 8, 2025
1 check passed
@nafisa-valieva nafisa-valieva deleted the NV_01.2025_IndianOffice3 branch January 8, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants