-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RangeError when opening .glft files #2319
Comments
Hi! Thanks for reporting and sorry for the delayed response! I'm surprised Calva would care at all about Can you make a reproduction project for this, with the setup, assets, and instructions for how to reproduce? I'm sure the gLTF Tools developers would be interested as well. This seems to happen in the intersection between two extensions, which I think is quite uncommon. |
To reproduce:
You'll find it bricks the Calva repl until you restart VSCode. |
Hello again. And new appologies for slow response times.... I now tried this and fail to launch the repl. I'm unfamiliar with dev container. VS Code asks me if I want to open the folder in a dev container and i say yes. Then after jacking in and evaluating the ns form in
I've also tried to start the repl from the command line in the docker container. But I get the same error. I'm guessing I am doing something wrong. Can you tell what it is from my description of what I do? |
Sorry I missed your response. It doesn't look like you did anything wrong. I'm not sure what happened there. I've updated the dependencies and just rebuilt from scratch. It should work now (launch dev container with "reopen in container" command). Of course make sure to jack-in as a deps.edn project. |
I still get the same error. Maybe it is something with that the manifold dependency looks like so: org.clojars.cartesiantheatrics/manifold3d$linux-cuda-x86_64 {:mvn/version "1.0.72"}
org.clojars.cartesiantheatrics/plexus {:mvn/version "0.0.9"} I am on a Mac. But I am running it in a container so maybe it should work with a linux dependency... |
Hmm, that's odd I just tried on a new computer. Perhaps another way to reproduce this issue is to just download a random .glb or .gltf (like this) and try to open it with gLTF Tools plugin. p.s. if you don't mind, could you possibly share the full stack trace for the error you're seeing? I'd like to identify the issue. |
This is
|
I see, thanks for sharing. There may be a bug with the CUDA support version not correctly falling back to CPU with your card . Using the classifier Feel free to close this one. It's a pretty minor issue. I found another plugin for rendering .glb files that has been working adequately for now. |
I'm not too familiar with 3D modeling. But I have some glb files lying around. So the problem should be reproducible with those? |
I could import the glb without issue. But since the repl isn't really functional to begin with maybe it doesn't expose the problem. I'll try in another project. |
I can reproduce it now. It's as easy as opening a .gltf file as json. I guess that involves the gLTF Tools extension enough. I'll try to create a minimal reproduction project. |
Here's a repro: https://github.com/PEZ/gltf-tools-repl-killer I think this should be brought to the gLTF Tools extension authors. Will do that later if you haven't beaten me to it. Now need to run. |
I managed to track down where things were failing in Calva and could remove the conflicting area from the picture. I really have no idea why the glTF Tools extension would have this effect on Calva, but now, with Calva v2.0.405, it's not a problem anymore. Thanks for reporting this problem! I think I will investigate it a bit further to see if I can understand what was happening. |
I could easily create a tiny extension that exposes the problem: https://github.com/PEZ/bencoder Reported the issue here: |
Hello,
I'm trying to use Calva in combination with gLTF Tools plugin. As soon as a preview (i.e. render in a webview) a .glft file within or outside the project, the calva repl hangs with:
; RangeError: Maximum call stack size exceeded
I've looked through the configuration options and tried add to all the the .*ignore files I could think of, but no luck. Is there any way to tell Calva to ignore these files?
The text was updated successfully, but these errors were encountered: