Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floats the nav bar when scrolling #182

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Floats the nav bar when scrolling #182

merged 2 commits into from
Jun 14, 2023

Conversation

AnonymousWalker
Copy link
Collaborator

@AnonymousWalker AnonymousWalker commented Oct 28, 2022 •
edited by jsarabia
Loading

image

Closes #150

This change is Reviewable

@AnonymousWalker AnonymousWalker linked an issue Oct 28, 2022 that may be closed by this pull request
Suggestion to User Interface #150
Open
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

mXaln
mXaln approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@mXaln mXaln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AnonymousWalker)

@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mXaln mXaln merged commit 81452e8 into audiobieldev.walink.org Jun 14, 2023
@mXaln mXaln deleted the aw-floating-navbar branch June 14, 2023 14:05
mXaln added a commit that referenced this pull request Jun 16, 2023
@AnonymousWalker @mXaln
Dev to Master: Updated de-chunker & Touch up UI (#187)
933788f 
* css position to float the navbar

* Updated de-chunker (tr-chunk-browser) (#186)

* Merge branch 'audiobieldev.walink.org' into aw-floating-navbar

* Merge pull request #182 from Bible-Translation-Tools/aw-floating-navbar

Floats the nav bar when scrolling

Co-Authored-By: Maxim <murmax82@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mXaln mXaln mXaln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion to User Interface
2 participants
@AnonymousWalker @mXaln