Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD lib.py to make argnorm usable as a library #28

Merged
merged 9 commits into from
Apr 15, 2024

Conversation

Vedanth-Ramji
Copy link
Member

Making argNorm better suited as a library.

  • Providing a separate map_to_aro function so argNorm can be used without the normalizers
  • Separated get_aro_mapping_table function from BaseNormalizer so it can be used independently

argnorm/general.py Outdated Show resolved Hide resolved
Copy link
Member

@luispedro luispedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about splitting to general. Is the goal that people import it as

from argnorm import general

?

Also, tests are needed

@Vedanth-Ramji
Copy link
Member Author

Yes, well now that I have renamed it to 'lib' it should be something like: from argnorm import lib or from argnorm.lib import *.

Is that ok?

argnorm/normalizers.py Outdated Show resolved Hide resolved
@Vedanth-Ramji Vedanth-Ramji changed the title ADD general.py ADD lib.py to make argnorm usable as a library Apr 10, 2024
@luispedro
Copy link
Member

Can you some notes to the Changelog about this?

@luispedro luispedro merged commit 546d6c3 into BigDataBiology:main Apr 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants