Drug Categorization Code Added #8
Conversation
There was a problem hiding this comment.
Thanks @Vedanth-Ramji for this.
See all the single-line comments, but I also think that you committed several files that are not necessary. Also, I think this was not done from the main branch as it unwittingly reverts 6baac44 and 19793d0
1) Simplified the process of determining 'confers_resistance_to_drug_class' or 'confers_resistance_to_antibiotic' 2) Only global constants are full caps, other variables are small letters 3) 'i' is not used for iterating
…ed reverting to old refactoring
|
The tests are now passing, but this commit has a lot of unnecessary material (remember that whatever you add in a commit will be in git's history forever). All the extra files should be removed before we can merge it Also, the comment about |
The approach I used was to integrate the drug categorization functions in the normalizer itself. While adding the ARO columns, I also add 'OVERALL CATEGORY OF DRUG CLASS' and 'CONFERS RESISTANCE TO IMMEDIATE DRUG CLASS' columns and use my drug categorization functions to get the data to be displayed in those columns.
I have included the drug categorization in the 'run' function of the base normalizer class, as the drug categorization functions only need ARO numbers as parameters, hence after normalization, differences between database syntaxes wouldn't matter for categorization code.