Skip to content

Commit

Permalink
make 'true' and 'false' options for types FlexItemGrowSize and FlexIt…
Browse files Browse the repository at this point in the history
…emShrinkSize deprecated and add a TODO comment to remove them for next major release

Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com>
  • Loading branch information
BigSamu committed Jan 12, 2024
1 parent 01e94ea commit 03ce677
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions src/components/flex/flex_item.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import React, { HTMLAttributes, FunctionComponent } from 'react';
import classNames from 'classnames';
import { CommonProps } from '../common';

// TODO: Remove 'true' and 'false' from the type definitions on next major release
export type FlexItemGrowSize =
| 0
| 1
Expand All @@ -44,9 +45,19 @@ export type FlexItemGrowSize =
| 8
| 9
| 10
/**
* @deprecated `true` will be removed in the next major release.
* Use numeric values instead.
*/
| true
/**
* @deprecated `false` will be removed in the next major release.
* Use numeric values instead.
*/
| false
| null;

// TODO: Remove 'true' and 'false' from the type definitions on next major release
export type FlexItemShrinkSize =
| 0
| 1
Expand All @@ -59,7 +70,15 @@ export type FlexItemShrinkSize =
| 8
| 9
| 10
/**
* @deprecated `true` will be removed in the next major release.
* Use numeric values instead.
*/
| true
/**
* @deprecated `false` will be removed in the next major release.
* Use numeric values instead.
*/
| false
| null;
export type FlexItemBasisValue = string | true | false | null;
Expand Down

0 comments on commit 03ce677

Please sign in to comment.