Skip to content

Commit

Permalink
updating breadcrumbs JSX according suggestion from maintainer for bet…
Browse files Browse the repository at this point in the history
…ter readability of code

Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com>
  • Loading branch information
BigSamu committed Dec 5, 2023
1 parent 9c0bcf0 commit 5ad83b3
Showing 1 changed file with 10 additions and 15 deletions.
25 changes: 10 additions & 15 deletions src/components/breadcrumbs/breadcrumbs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -272,23 +272,18 @@ export const OuiBreadcrumbs: FunctionComponent<OuiBreadcrumbsProps> = ({
</OuiInnerText>
);

const breadcrumbWallClasses = isFirstBreadcrumb
? classNames('ouiBreadcrumbWall', {
'ouiBreadcrumbWall--single': isLastBreadcrumb,
})
: breadcrumbWrapperClasses;

const wrapper = (
<div className={breadcrumbWallClasses}>
{isFirstBreadcrumb ? (
<div className={breadcrumbWrapperClasses}>{link}</div>
) : (
link
)}
</div>
const breadcrumbWallClasses = classNames('ouiBreadcrumbWall', {
'ouiBreadcrumbWall--single': isFirstBreadcrumb && isLastBreadcrumb,
});

const wrapper = <div className={breadcrumbWrapperClasses}>{link}</div>;
const wall = isFirstBreadcrumb ? (
<div className={breadcrumbWallClasses}>{wrapper}</div>
) : (
wrapper
);

return <Fragment key={index}>{wrapper}</Fragment>;
return <Fragment key={index}>{wall}</Fragment>;
});

// Use the default object if they simply passed `true` for responsive
Expand Down

0 comments on commit 5ad83b3

Please sign in to comment.