Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walk Data Entry - Verification check code optimisation #29

Open
andrewvanbreda opened this issue Apr 25, 2023 · 4 comments
Open

Walk Data Entry - Verification check code optimisation #29

andrewvanbreda opened this issue Apr 25, 2023 · 4 comments
Assignees

Comments

@andrewvanbreda
Copy link
Collaborator

As per email conversation with John...
The species grid on the Walk Data Entry page (https://ukbms.org/input-data) is making a call to check_verification_rules on the Warehouse, but is doing so with a call per species row, rather than as one request with multiple data returned.
Further to this, these calls are asynchronous, and thus hit the server hard as they run in parallel.

  1. Change to one request
  2. Make sure page displays before checks are complete, then update the page.
    Possibly display "verification checks running…" message with spinner.

David to assign and prioritise

@andrewvanbreda
Copy link
Collaborator Author

@DavidRoy
Just realised I can't assign on this project, I had intended to assign this to you to decide about priority, and who is to deal with this.

@colinharrower
Copy link
Contributor

@andrewvanbreda I've sent an invite to you that should give you the ability to manage issues and assign in this repo

@andrewvanbreda
Copy link
Collaborator Author

Hi @colinharrower
Thank you.
Yes, I can assign issues now.

@andrewvanbreda
Copy link
Collaborator Author

Note:
David has requested the temporary disabling of verification check functionality to improve site speed.
This appears to be controlled by the "Server range validation" checkbox on the data entry page Edit Tab, I have switched this off for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants