From c4fd4c2f7465ab124bf3f796b87cc4ec13bb3d20 Mon Sep 17 00:00:00 2001 From: Bionus Date: Wed, 7 Jun 2023 19:17:48 +0200 Subject: [PATCH 1/8] fix: save settings not showing in QML version (fix #2978) --- .../settings/pages/SaveSettingsPage.qml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gui-qml/src/components/settings/pages/SaveSettingsPage.qml b/src/gui-qml/src/components/settings/pages/SaveSettingsPage.qml index 50178b56d..ff809e0ef 100644 --- a/src/gui-qml/src/components/settings/pages/SaveSettingsPage.qml +++ b/src/gui-qml/src/components/settings/pages/SaveSettingsPage.qml @@ -68,7 +68,7 @@ ColumnLayout { Repeater { model: ListModel { ListElement { - name: globals.tagTypes["general"] + name: qsTr("General") key: "general" enableShorter: false defaultEmpty: "" @@ -76,7 +76,7 @@ ColumnLayout { defaultSeparator: " " } ListElement { - name: globals.tagTypes["artist"] + name: qsTr("Artist") key: "artist" enableShorter: false defaultEmpty: "anonymous" @@ -84,7 +84,7 @@ ColumnLayout { defaultSeparator: "+" } ListElement { - name: globals.tagTypes["copyright"] + name: qsTr("Copyright") key: "copyright" enableShorter: true defaultEmpty: "misc" @@ -92,7 +92,7 @@ ColumnLayout { defaultSeparator: "+" } ListElement { - name: globals.tagTypes["character"] + name: qsTr("Character") key: "character" enableShorter: false defaultEmpty: "unknown" @@ -100,7 +100,7 @@ ColumnLayout { defaultSeparator: "+" } ListElement { - name: globals.tagTypes["model"] + name: qsTr("Model") key: "model" enableShorter: false defaultEmpty: "unknown" @@ -108,7 +108,7 @@ ColumnLayout { defaultSeparator: "+" } ListElement { - name: globals.tagTypes["photo_set"] + name: qsTr("Photo set") key: "photo_set" enableShorter: false defaultEmpty: "unknown" @@ -116,7 +116,7 @@ ColumnLayout { defaultSeparator: "+" } ListElement { - name: globals.tagTypes["species"] + name: qsTr("Species") key: "species" enableShorter: false defaultEmpty: "unknown" @@ -124,7 +124,7 @@ ColumnLayout { defaultSeparator: "+" } ListElement { - name: globals.tagTypes["meta"] + name: qsTr("Meta") key: "meta" enableShorter: false defaultEmpty: "none" From 43de3d8c913cc9df5e261f5ce5475cf606cf7e40 Mon Sep 17 00:00:00 2001 From: Bionus Date: Thu, 8 Jun 2023 22:20:00 +0200 Subject: [PATCH 2/8] fix: remove warning in GA4 code about User-Agent type --- src/lib/src/utils/google-analytics-4.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/src/utils/google-analytics-4.cpp b/src/lib/src/utils/google-analytics-4.cpp index 123a7400c..88b4c0421 100644 --- a/src/lib/src/utils/google-analytics-4.cpp +++ b/src/lib/src/utils/google-analytics-4.cpp @@ -136,7 +136,7 @@ void GoogleAnalytics4::sendEvent(const QString &name, const QVariantMap ¶met url.setQuery(query); QNetworkRequest request(url); - request.setHeader(QNetworkRequest::UserAgentHeader, userAgent()); + request.setHeader(QNetworkRequest::UserAgentHeader, userAgent().toLatin1()); QNetworkReply *reply = m_networkAccessManager->get(request); connect(reply, &QNetworkReply::finished, reply, &QNetworkReply::deleteLater); From ac2f8a570f757c40182f076958cb857bec5ade79 Mon Sep 17 00:00:00 2001 From: Bionus Date: Tue, 20 Jun 2023 01:26:46 +0200 Subject: [PATCH 3/8] build: enable arm64-v8a ABI build --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0c38f6b29..4767ea521 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -583,7 +583,7 @@ jobs: export ANDROID_NDK_ROOT="${ANDROID_HOME}/ndk/${ANDROID_NDK_VERSION}" cmake ../src -DCMAKE_BUILD_TYPE=Release -DNIGHTLY=$GRABBER_IS_NIGHTLY -DCOMMIT="$GITHUB_SHA" -DVERSION="$GRABBER_VERSION" -DKEYSTORE_PASSWORD="${{ secrets.ANDROID_KEYSTORE_PASSWORD }}" \ -DANDROID_ABI:STRING=armeabi-v7a \ - -DANDROID_BUILD_ABI_arm64-v8a:BOOL=OFF \ + -DANDROID_BUILD_ABI_arm64-v8a:BOOL=ON \ -DANDROID_BUILD_ABI_armeabi-v7a:BOOL=ON \ -DANDROID_BUILD_ABI_x86:BOOL=OFF \ -DANDROID_BUILD_ABI_x86_64:BOOL=OFF \ From 820771e34a7468b37813b84dbda35a201d0800c5 Mon Sep 17 00:00:00 2001 From: Bionus Date: Fri, 23 Jun 2023 00:38:43 +0200 Subject: [PATCH 4/8] fix: stop using infinite scroll when disabled (fix #2987) --- src/gui-qml/src/components/GalleryScreen.qml | 2 +- src/gui-qml/src/components/SearchScreen.qml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gui-qml/src/components/GalleryScreen.qml b/src/gui-qml/src/components/GalleryScreen.qml index 7bf0ffe5f..c02d3af2a 100644 --- a/src/gui-qml/src/components/GalleryScreen.qml +++ b/src/gui-qml/src/components/GalleryScreen.qml @@ -89,7 +89,7 @@ Page { onOpenImage: mainStackView.push(imageScreen, { index: index }) onRefresh: galleryLoader.load() onAppendNext: { - if (galleryLoader.hasNext) { + if (infiniteScroll && galleryLoader.hasNext) { root.appendResults = true root.page++ galleryLoader.load() diff --git a/src/gui-qml/src/components/SearchScreen.qml b/src/gui-qml/src/components/SearchScreen.qml index a2634d94d..3fdb9b1c0 100644 --- a/src/gui-qml/src/components/SearchScreen.qml +++ b/src/gui-qml/src/components/SearchScreen.qml @@ -162,7 +162,7 @@ Page { onOpenImage: mainStackView.push(imageScreen, { index: index }) onRefresh: load() onAppendNext: { - if (pageLoader.hasNext) { + if (infiniteScroll && pageLoader.hasNext) { searchTab.appendResults = true searchTab.page++ searchTab.load() From 6983afa6de1e35a58ac838343214736cb14797ba Mon Sep 17 00:00:00 2001 From: Bionus Date: Fri, 23 Jun 2023 01:05:57 +0200 Subject: [PATCH 5/8] fix: page count parsing on r34.us (fix #2990) --- src/sites/Rule34.us Gelbooru/model.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/sites/Rule34.us Gelbooru/model.ts b/src/sites/Rule34.us Gelbooru/model.ts index d82cf30a5..feaf3ae4a 100755 --- a/src/sites/Rule34.us Gelbooru/model.ts +++ b/src/sites/Rule34.us Gelbooru/model.ts @@ -31,10 +31,15 @@ export const source: ISource = { return "/index.php?r=posts/index&q=" + search + (page === 0 ? '' : "&page=" + page); }, parse: (src: string): IParsedSearch => { - const pageCount = Grabber.regexToConst("page", '