Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed downloads are treated as complete #3299

Open
typhoon71 opened this issue Sep 19, 2024 · 0 comments
Open

Failed downloads are treated as complete #3299

typhoon71 opened this issue Sep 19, 2024 · 0 comments
Labels

Comments

@typhoon71
Copy link

Bug description
Failed downloads are treated as complete and are not retried once restarted.

Steps to reproduce

  • Have some monitor active
  • launch grabber
  • if the download fails, it's still counted as success (see last success colum on monitors)

Expected behavior
Failed download should not be counted as downloaded and retried next monitor tick.
Also the date should stay the previous one, it failed the synch after all.

Context

  • yesterday was watching the log and saw that all downloads failed
  • I noticed that the page would get parsed, the new pics recognized, but then they failed to download
  • I realized that the source site (yandere) was down / in pieces / ...
  • I noticed last success colum on monitors was updated with current date - even if they failed to download
  • also today, with the site back up, those pics weren't resumed
  • I had to force a full recheck (download all) to get them

System information

  • OS: [e.g. Windows 7 SP1]
  • Grabber version: [e.g. 7.11.2]
@typhoon71 typhoon71 added the bug label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant