Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix peer dependency issue to NestJS packages #27

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

notTanveer
Copy link
Contributor

Updated the following NestJS packages to ensure compatibility and resolve peer dependency conflicts:

  • @nestjs/common: ^10.4.1
  • @nestjs/config: ^3.2.3
  • @nestjs/core: ^10.4.1
  • @nestjs/microservices: ^10.4.1
  • @nestjs/passport: ^10.0.0
  • @nestjs/schedule: 3.0.0

These updates address the peer dependency requirements for @nestjs/core and related packages, ensuring a smooth installation process without the need for the --force flag.
Updated the package.json and verified compatibility across all dependencies.

Copy link
Collaborator

@theanmolsharma theanmolsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to commit the changes to the lock files

@theanmolsharma
Copy link
Collaborator

Additionally, we should also update the vulnerable dependencies in this PR itself

@theanmolsharma
Copy link
Collaborator

Fixes #24

package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@theanmolsharma theanmolsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! Thanks for doing this.

@theanmolsharma theanmolsharma merged commit 53b4c73 into Bitshala-Incubator:main Aug 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants