feat: add e2e test framework #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me. |
notTanveer
approved these changes
Aug 31, 2024
Signed-off-by: Anmol Sharma <anmolsharma0234@gmail.com>
theanmolsharma
force-pushed
the
e2e-test-framework
branch
from
6785ea6
to
7855a1d
Compare
Signed-off-by: Anmol Sharma <anmolsharma0234@gmail.com>
notTanveer
approved these changes
Sep 1, 2024
aruokhai
reviewed
Sep 2, 2024
Comment on lines
+46
to
+59
| run: docker compose -f "./e2e/helpers/docker/docker-compose.yml" up -d | ||
| - name: Cache node modules | ||
| id: cache-node-modules | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: node_modules | ||
| key: node-modules-${{ hashFiles('package-lock.json') }} | ||
| - name: Install Dependencies | ||
| if: steps.cache-node-modules.outputs.cache-hit != 'true' | ||
| run: npm install | ||
| - name: Start indexer | ||
| run: npm run start:e2e > indexer.log 2>&1 & | ||
| - name: Wait for indexer to become available |
There was a problem hiding this comment.
Seems Good to me . What is your opinion regarding putting indexer also in a container ?
There was a problem hiding this comment.
Do you mean, creating a Dokcerfile, building the image, and running that image here?
There was a problem hiding this comment.
Yes, we can create a docker image of the indexer and run it in the same service as bitcoind
There was a problem hiding this comment.
The problem here is that we'd need to build the image again and again for every run. This could slow down the CI considerably.
This will definitely be a good change but let's do it in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.