Feat/config validation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nesopie
force-pushed
the
feat/config-validation
branch
2 times, most recently
from
93b2294 to
d03a6ba
Compare
|
umm, okay. I don't understand what issues could have arisen with squashing. |
theanmolsharma
requested changes
Apr 28, 2024
There was a problem hiding this comment.
The changes look solid, few final suggestions before we merge.
- Please sign all your commits. (2nd commit is not signed)
- Please rebase on main. To merge, we should have a linear history.
- Please remove any unnecessary commit descriptions and change the commit messages to the following:
- chore: add class-transformer and class-validator as dependencies.
- feat: add config validation
Nesopie
force-pushed
the
feat/config-validation
branch
6 times, most recently
from
518b358 to
0a00546
Compare
theanmolsharma
approved these changes
Apr 28, 2024
theanmolsharma
requested changes
Apr 28, 2024
Signed-off-by: ayman <aymanshaik1015@gmail.com>
Signed-off-by: ayman <aymanshaik1015@gmail.com>
Nesopie
force-pushed
the
feat/config-validation
branch
from
87786b5 to
934092d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@theanmolsharma Had issue with squashes on there :/. This PR has all the updated changes