feat: update scanning to match specification in BIP352

Signed-off-by: Anmol Sharma <anmolsharma0234@gmail.com>
Bitshala-Incubator · Mar 3, 2024 · 3316c64 · 3316c64
1 parent 77172c6
commit 3316c64
Show file tree

Hide file tree

Showing 3 changed files with 329 additions and 201 deletions.
diff --git a/packages/core/src/scanning.ts b/packages/core/src/scanning.ts
@@ -1,7 +1,6 @@
-import { serialiseUint32 } from './utility.ts';
+import { createTaggedHash, serialiseUint32 } from './utility.ts';
 import { LabelMap } from './interface.ts';
 import secp256k1 from 'secp256k1';
-import createHash from 'create-hash';
 import { Buffer } from 'buffer';
 
 // Handle additional label-related logic
@@ -78,13 +77,13 @@ export const scanOutputs = (
     scanPrivateKey: Buffer,
     spendPublicKey: Buffer,
     sumOfInputPublicKeys: Buffer,
-    outpointHash: Buffer,
+    inputHash: Buffer,
     outputs: Buffer[],
     labels?: LabelMap,
 ): Map<string, Buffer> => {
     const ecdhSecret = secp256k1.publicKeyTweakMul(
         sumOfInputPublicKeys,
-        secp256k1.privateKeyTweakMul(scanPrivateKey, outpointHash),
+        secp256k1.privateKeyTweakMul(scanPrivateKey, inputHash),
         true,
     );
 
@@ -94,9 +93,10 @@ export const scanOutputs = (
     let counterIncrement = 0;
 
     do {
-        const tweak = createHash('sha256')
-            .update(Buffer.concat([ecdhSecret, serialiseUint32(n)]))
-            .digest();
+        const tweak = createTaggedHash(
+            'BIP0352/SharedSecret',
+            Buffer.concat([ecdhSecret, serialiseUint32(n)]),
+        );
         counterIncrement = processTweak(
             spendPublicKey,
             tweak,