Reverted back TaskPool changes

BlackPhlox · Nov 11, 2023 · 41c6521 · 41c6521
1 parent a584976
commit 41c6521
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 25 deletions.
diff --git a/src/input.rs b/src/input.rs
@@ -174,18 +174,16 @@ fn setup(mut commands: Commands, settings: Res<MidiInputSettings>) {
     let (m_sender, m_receiver) = crossbeam_channel::unbounded::<Message>();
     let (r_sender, r_receiver) = crossbeam_channel::unbounded::<Reply>();
 
-    //Got issues with the rewrite : https://github.com/bevyengine/bevy/pull/10008
+    //Got issues with the taskpool rewrite : https://github.com/bevyengine/bevy/pull/10008
     let thread_pool = IoTaskPool::get_or_init(|| TaskPool::new());
-    thread_pool.scope(|s|{
-        s.spawn(async {
-            MidiInputTask {
-                receiver: m_receiver,
-                sender: r_sender,
-                settings: settings.clone(),
-                input: None,
-                connection: None,
-            }
-        })
+    thread_pool.spawn({
+        MidiInputTask {
+            receiver: m_receiver,
+            sender: r_sender,
+            settings: settings.clone(),
+            input: None,
+            connection: None,
+        }
     });
 
     commands.insert_resource(MidiInput {

diff --git a/src/output.rs b/src/output.rs
@@ -136,20 +136,8 @@ fn setup(mut commands: Commands, settings: Res<MidiOutputSettings>) {
     let (m_sender, m_receiver) = crossbeam_channel::unbounded();
     let (r_sender, r_receiver) = crossbeam_channel::unbounded();
 
+    //Got issues with the taskpool rewrite : https://github.com/bevyengine/bevy/pull/10008
     let thread_pool = IoTaskPool::get_or_init(|| TaskPool::new());
-    thread_pool.scope(|s|{
-        s.spawn(async {
-            MidiOutputTask {
-                receiver: m_receiver,
-                sender: r_sender,
-                settings: settings.clone(),
-                output: None,
-                connection: None,
-            }
-        })
-    });
-    /*   
-    let thread_pool = IoTaskPool::get();
     thread_pool
         .spawn(MidiOutputTask {
             receiver: m_receiver,
@@ -159,7 +147,6 @@ fn setup(mut commands: Commands, settings: Res<MidiOutputSettings>) {
             connection: None,
         })
         .detach();
-    */
 
     commands.insert_resource(MidiOutput {
         sender: m_sender,