fix: note on message with velocity of 0 is note off

BlackPhlox · Dec 6, 2024 · a60cbac · a60cbac
1 parent 6b46b89
commit a60cbac
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/lib.rs b/src/lib.rs
@@ -26,12 +26,13 @@ impl From<[u8; 3]> for MidiMessage {
 impl MidiMessage {
     #[must_use]
     pub fn is_note_on(&self) -> bool {
-        (self.msg[0] & 0b1111_0000) == NOTE_ON_STATUS
+        (self.msg[0] & 0b1111_0000) == NOTE_ON_STATUS && self.msg[2] != 0
     }
 
     #[must_use]
     pub fn is_note_off(&self) -> bool {
         (self.msg[0] & 0b1111_0000) == NOTE_OFF_STATUS
+            || ((self.msg[0] & 0b1111_0000) == NOTE_ON_STATUS && self.msg[2] == 0)
     }
 
     /// Get the channel of a message, assuming the message is not a system message.