Upgrade to Bevy 0.15 #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in Bevy 0.15 where the bevy_gtlf feature will fail compilation: bevyengine/bevy#16671. In the meantime, dev-dependencies enables all features.
Mysteriously, the input ports have disappeared? This should be investigated
…ing) bevy_mod_picking should be upgraded to 0.15: aevyrie/bevy_mod_picking#375 Unsure how to proceed, could remove this dependency for this example to compile.
|
Huge kudos for doing this! Although I won’t be able to review it today, let me know if you need anything else from me in lieu of this and #43. |
|
I've made an analogous example to resolve the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I'd like to use your crate in 0.15. There are a few snags upgrading detailed below. Not sure how you'd like me to handle these. In general though, the upgrade works!
all-featuresto true for dev-dependencies. Workaround for Compilation Failure: Regression in enablingbevy_gltffeature bevyengine/bevy#16671piano.rs) to use updated Components (Existing bundles were deprecated.TextSectionappears to have been removed)bevy_mod_pickingis not ready for 0.15: Bevy 0.15 aevyrie/bevy_mod_picking#375. This dependency is used by thepianoexample. I'll see to removing itinput.rsalways panics on connect on my computer, including on the main branch. I'll look to fix.I'm not sure how you would like to proceed on the
piano.rsexample. I think this example is possible without this dependency.Additionally, would it be alright to lock dependency versioning for this crate (remove
Cargo.lockfrom.gitignore)? I would like to ensure consistent behavior for this crate since bevy is a tumultuous ecosystem.