chore: fix workflows

Blazity · Oct 31, 2024 · d08e1f1 · d08e1f1
1 parent 93fd01a
commit d08e1f1
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 3 deletions.
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -43,7 +43,6 @@ jobs:
               should-run: needs.check-changes.outputs.shopify-algolia,
             },
           ]
-    if: ${{ fromJson(matrix.app.should-run) }}
 
     environment: Production
     name: Build and Test (${{ matrix.app.name }})
@@ -66,6 +65,15 @@ jobs:
       REPLICATE_API_KEY: ${{ secrets.REPLICATE_API_KEY }}
 
     steps:
+      - name: Check if should run
+        id: should-run
+        run: |
+          should_run=${{ matrix.app.should-run }}
+          if [ "$should_run" != "true" ]; then
+            echo "Skipping job as no changes detected for ${{ matrix.app.name }}"
+            exit 1
+          fi
+
       - uses: actions/checkout@v4
       - run: echo "node_version=$(cat .github/nodejs.version)" >> $GITHUB_ENV
       - name: "Use node ${{ env.node_version }}"

diff --git a/.github/workflows/nextjs_bundle_analysis.yml b/.github/workflows/nextjs_bundle_analysis.yml
@@ -49,7 +49,6 @@ jobs:
               should-run: needs.check-changes.outputs.shopify-algolia,
             },
           ]
-    if: ${{ fromJson(matrix.app.should-run) }}
 
     environment: Production
     name: Analyze (${{ matrix.app.name }})
@@ -71,6 +70,15 @@ jobs:
       REPLICATE_API_KEY: ${{ secrets.REPLICATE_API_KEY }}
 
     steps:
+      - name: Check if should run
+        id: should-run
+        run: |
+          should_run=${{ matrix.app.should-run }}
+          if [ "$should_run" != "true" ]; then
+            echo "Skipping job as no changes detected for ${{ matrix.app.name }}"
+            exit 1
+          fi
+
       - uses: actions/checkout@v4
       - run: echo "node_version=$(cat .github/nodejs.version)" >> $GITHUB_ENV
       - name: "use node ${{ env.node_version }}"

diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
@@ -46,7 +46,6 @@ jobs:
               should-run: needs.check-changes.outputs.shopify-algolia,
             },
           ]
-    if: ${{ fromJson(matrix.app.should-run) }}
 
     environment: test
     name: E2E Tests (${{ matrix.app.name }})
@@ -70,6 +69,15 @@ jobs:
       cancel-in-progress: true
 
     steps:
+      - name: Check if should run
+        id: should-run
+        run: |
+          should_run=${{ matrix.app.should-run }}
+          if [ "$should_run" != "true" ]; then
+            echo "Skipping job as no changes detected for ${{ matrix.app.name }}"
+            exit 1
+          fi
+
       - uses: actions/checkout@v4
       - run: echo "node_version=$(cat .github/nodejs.version)" >> $GITHUB_ENV
       - name: "use node ${{ env.node_version }}"