Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added model dumps #49

Merged
merged 17 commits into from
Dec 18, 2024
Merged

Added model dumps #49

merged 17 commits into from
Dec 18, 2024

Conversation

cszsol
Copy link
Collaborator

@cszsol cszsol commented Nov 14, 2024

No description provided.

@cszsol cszsol requested a review from BoBer78 November 14, 2024 13:48
@WonderPG
Copy link
Contributor

This PR was rather to transform the outputs of the tools, not of the app's endpoints. Each tool returns a pydantic class of some sort, and instead of returning the actual pydantic class we should return model.model_dump().

@kanesoban
Copy link
Collaborator

This PR was rather to transform the outputs of the tools, not of the app's endpoints. Each tool returns a pydantic class of some sort, and instead of returning the actual pydantic class we should return model.model_dump().

I see. I changed the output of the tools. Let me know if it is ok.

BoBer78
BoBer78 previously approved these changes Dec 18, 2024
Copy link
Contributor

@BoBer78 BoBer78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@kanesoban kanesoban merged commit 35cbca5 into main Dec 18, 2024
5 checks passed
@kanesoban kanesoban deleted the store_json branch December 18, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants