rm nexus sdk usage and dependency #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssssarah
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
==========================================
- Coverage 75.61% 74.76% -0.86%
==========================================
Files 103 104 +1
Lines 6779 6883 +104
==========================================
+ Hits 5126 5146 +20
- Misses 1653 1737 +84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lecriste
reviewed
May 30, 2024
lecriste
approved these changes
May 30, 2024
crisely09
reviewed
May 31, 2024
|
Hmm why to call things: |
MFSY
pushed a commit
that referenced
this pull request
Jul 5, 2024
* rm sdk usage from bluebrainexus store file * rm sdk usage from utils * rm sdk usage from service * rm nexussdk from test * lint * fix patch * change usage of project_fetch function for successful patching in tests * rename module of sdk methods * remove leftover image from store * missing file * restore config * remove s from file name * missing the file, again --------- Co-authored-by: Cristina E. González-Espinoza <crisbeth46@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've put all the code from the sdk that was used in the file previous_sdk_usage, with the change that the endpoint and token are provided as parameters (as opposed to setting environment variables)
No design thought really went into this, it's a fast solution, up to change
(preparatory work so that we specify a token as a callable, without having to handle setting the nexussdk environment variable)