Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix // Fix error when multi fetch is called with 0 resources #1397

Merged

Conversation

Dinika
Copy link
Contributor

@Dinika Dinika commented Oct 4, 2023

Fixes #
An error is shown to the user when we call multi-fetch api with empty array. (for example, in staging, choose bbp/mouselight project, Dataset type, subject.species.label path and does not contain predicate).

We can remove this error from being displayed by simply not calling the api if no match was found to the predicate (i.e. when the ES search api returned 0 hits)

Screenshot from 2023-10-04 13-55-20

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@Dinika Dinika merged commit d1cd709 into develop Oct 4, 2023
@Dinika Dinika deleted the hotfix/dont-bulk-fetch-resources-if-no-resources-are-found branch October 4, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants