Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #1398

Merged
merged 78 commits into from
Oct 5, 2023
Merged

Develop #1398

merged 78 commits into from
Oct 5, 2023

Conversation

Dinika
Copy link
Contributor

@Dinika Dinika commented Oct 4, 2023

Fixes #

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

Dinika added 30 commits September 13, 2023 09:40
@Dinika
3911 // Make cypress ci tests easy to debug
e1ac0db
@Dinika
3911 // Fix cypress tests by creating sesssions correctly
155e8f9 
The responses sent from keycloak can only be accepted by the browser if
SameSite cookies are None and mixed content is enabled

Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
@Dinika
3911 // Modify cypress run in ci
5fde41f
@Dinika
Cypress tests should run without sudo permissions in ci
59e6f26
@Dinika
3911 // Tests run locally with localuser
982ff7f
@Dinika
Add cypress environment file
6e199c3 
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
@Dinika
3911 // Can be removed later - Simplify test assertions
23c1222
@Dinika
3911 // GitHub user should own the file
cda3bfb 
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
@Dinika
add debug logs
434d859
@Dinika
Run cypress container as user
de4fda0
@Dinika
Use trigger click instead of click event
f044c93
@Dinika
Force click buttons and wait longer for the studio navigation
c8fa69d
@Dinika
Chown everything
534cea5
@Dinika
1. Remove debug logs, dont copy into container, force click
f0b179a
@Dinika
f remove temo
d0a049d
@Dinika
3911 // Add back analysis file
b234d40
@Dinika
wait for navaigation to studio
37b18db
@Dinika
3911 // Wait for redirection
737c81d
@Dinika
3911 // hard wait
f4bc900
@Dinika
3911 // Run analysis plugin test also
ef1f0b5
@Dinika
3911 // Use latest chrome and cypress
6154160
@Dinika
3911 // Run without recording on cypress cloud
79fa221
@Dinika
Remove all cypress things owned by root
3ca2605
@Dinika
run as user 1000
9ae807c
@Dinika
3911 // Run tests by spec
3318ff1
@Dinika
3911 // Run in headless mode in ci
16af98c
@Dinika
3911 // no need to add user to docker compose instead pass user in exec
eeff23e
@Dinika
3911 // Remove chowing
4d8d8ea
@Dinika
3911 // Pass user id as env variabl to cypress container
740c350
@Dinika
login to fix limit
dd47127 
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
Dinika and others added 27 commits September 13, 2023 09:40
@Dinika
3911 // Disable sandbox to e2e tests stop running
2d5b604
@Dinika
3911 // Disable uid because cypress hangs
e31a085
@Dinika
3911 // copy contents to see if permissions issue is resolved
bc989b8
@Dinika
3911 // Pass uid to exec to see logs
cd792db 
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
@Dinika
3911 // Pass user id in docker compose
dc46d13
@Dinika
3911 // Run without mounting volumes
4344b2d
@Dinika
3911 // Use yaml line folding
d2845eb
@Dinika
3911 // Decrease timeout
7fb4351
@Dinika
3911 // Add timeout to job
7df2f72
@Dinika
3911 // Increase timeout to 50 sec
625dcec
@Dinika
3911 // Bring back force clicks
33af710
@Dinika
3911 // Try using linux timeout command
e3ae826
@Dinika
3911 // dd verbose logs
2d660a6
@Dinika
3911 // Remove old files
fcec823
@Dinika
3911 // Remove changes that are not needed in source code
8a041e9
@Dinika
3911 // Kill cypress if tests dont complete in 20 minutes
71aa1dc
@Dinika
3911 // Add documentation to run e2e tests
db7e5c1
@Dinika
3911 // Revert change setting config
293b4c4
@Dinika
3911 // Only push headless new if not headed
fb38164
@Dinika
3911 // Headless local should run on same browser as headless ci(cy:ci)
cefdde5
@Dinika
3911 // Let user choose browser when running cypress headless locally
fe24816
@Dinika
3911 // Remove test isolation
797b53e
@Dinika
4093 // Get exhaustive list of paths from graph analytics
6f7fe77 
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
@Dinika
4083 // Run predicates in backend
8b819ef 
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
@Dinika
4289 // Add utility function for multi-get
88f5a67 
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
@Dinika
Hotfix // Fix error when multi fetch is called with 0 resources
d1cd709
@bilalesi
Merge branch 'main' into develop
9e640fb
@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (a4dca23) 49.05% compared to head (d1cd709) 49.65%.
Report is 1 commits behind head on main.

❗ Current head d1cd709 differs from pull request most recent head 9e640fb. Consider uploading reports for the commit 9e640fb to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
+ Coverage   49.05%   49.65%   +0.59%     
==========================================
  Files         248      249       +1     
  Lines       11170    11338     +168     
  Branches     2623     2653      +30     
==========================================
+ Hits         5480     5630     +150     
- Misses       5657     5672      +15     
- Partials       33       36       +3
Files Coverage Δ
src/shared/components/EditTableForm.tsx 40.53% <100.00%> (ø)
src/shared/molecules/TypeSelector/TypeSelector.tsx 81.39% <ø> (-0.22%) ⬇️
src/subapps/dataExplorer/DataExplorer.tsx 91.97% <100.00%> (+0.15%) ⬆️
...studioLegacy/containers/WorkspaceMenuContainer.tsx 56.47% <ø> (ø)
src/subapps/dataExplorer/DataExplorerUtils.tsx 86.71% <91.07%> (+11.71%) ⬆️
src/subapps/dataExplorer/PredicateSelector.tsx 96.44% <89.79%> (-0.27%) ⬇️

... and 68 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dinika Dinika merged commit baf3400 into main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilalesi bilalesi bilalesi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dinika @codecov-commenter @bilalesi