Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration: Fix failing E2E tests #1504

Closed
wants to merge 22 commits into from
Closed

Migration: Fix failing E2E tests #1504

wants to merge 22 commits into from

Conversation

danburonline
Copy link
Contributor

@danburonline danburonline commented Feb 21, 2024 •
edited
Loading

There were still some failing E2E tests. This PR fixes this. One E2E test is still failing, tbc.

CleanShot 2024-02-23 at 1  16 41

Fixes #

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@danburonline danburonline self-assigned this Feb 21, 2024
@danburonline danburonline changed the base branch from main to migration-merge February 21, 2024 14:15
This was referenced Feb 22, 2024
Merged
Merged
Dinika and others added 17 commits February 23, 2024 13:55
@Dinika
Fix loading of resources that have encoded chars in id
664abe8 
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
@danburonline
Improve error handling in failing E2E test
0ce678d
@danburonline
Improve logging of createResource Cypress task
17e6ed3
@danburonline
Try clicking on toggle directly via test ID
cf350e3
@Dinika @danburonline
Fix loading of resources that have encoded chars in id
5c8b5de 
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
@danburonline
Try to fix E2E test
b15a0df
@danburonline
Change NPM script from cy:open to e2e:open
92b48c4
@danburonline
Explicitly await an element in failing E2E test
9876d45
@danburonline
Clean SearchContainer component
6584b2e
@danburonline
Revert previous changes
00630af
@danburonline
Add example GH Action test file for debugging
890e470
@Dinika @danburonline
Fix loading of resources that have encoded chars in id
284604f 
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
@Dinika @danburonline
Fix loading of resources that have encoded chars in id
39ddbf3 
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
@danburonline
Fix typo
2ed5377
@danburonline
Adjust manifest file
ae94bac
@danburonline
Enhance manifest some more and add app screenshots
28c90d9
@Dinika @danburonline
Studio // Dont override column config when one aleady exists
a0b8672 
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
@danburonline danburonline force-pushed the fix/migration/e2e-tests branch from da31aa2 to a0b8672 Compare February 23, 2024 13:28
@bilalesi bilalesi deleted the fix/migration/e2e-tests branch December 5, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danburonline danburonline

Labels
fix migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danburonline @Dinika