-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re introduce fulltext search #1523
Re introduce fulltext search #1523
Conversation
Also, another feedback: Currently, when you're in an input field and type something with a |
aab49b5
to
3c17345
Compare
we never take dark mode into consideration, the whole app built with light mode in mind, |
I changed this to |
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
update: refactor content of search body area
3c17345
to
1e09929
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. posted a question.
deprecated: false, | ||
}), | ||
select: data => data._results, | ||
staleTime: 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The staleTime
in milliseconds right? 2 milliseconds sounds too low to me. Did you mean 2000 ms instead?
fixes: 4723
cmdk
component for fulltext search.Description
How has this been tested?
Types of changes
Checklist: