Fix interface for stability and consistency #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanturing-bluemirrors
requested review from
makaveli10,
shivamswarnkar and
mavihs7
and removed request for
makaveli10 and
shivamswarnkar
shivamswarnkar
requested review from
ankitnamdeo34 and
thegrogu
and removed request for
mavihs7
|
@alanturing-bluemirrors @mavihs7 are you guys still working on this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to apply changes to the current interface based on the issues or misconfigurations identified during development.
Identified issues:
init()method inICoreaccepts parametersclasseswhich is biased to object detection and doesn't have application in other use cases such as: Image Text Matching (no classes to process), Background removal (no classes to process), etc.Steps to regain control of the interface:
classesas it has minimal use in the interface. Re-arrange the interface call from theinit()method inYolov5 coreto ensure consistency with development.Tests performed:
DO NOT MERGE THE PR UNTIL THE THREE MAINTAINERS HAVE VERIFIED AND APPROVED THE CHANGES