feat: custom cluster configs ✨ #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add cluster config option in ClusterOptions - add cluster config parsing - add cluster config pytest arg - add unit tests
Schille
reviewed
Sep 30, 2024
Schille
reviewed
Sep 30, 2024
Schille
reviewed
Sep 30, 2024
| group = parser.getgroup("k8s") | ||
| group.addoption( | ||
| k8s_group = parser.getgroup("k8s") | ||
| k8s_group.addoption( | ||
| "--k8s-cluster-name", |
There was a problem hiding this comment.
Do we have a mutual exlusion of --k8s-cluster-name and --k8s-cluster-config or precedence?
There was a problem hiding this comment.
Not yet. I think it should be mutually exclusive and the name should be required when provider config is given
Schille
reviewed
Sep 30, 2024
| + opts | ||
| ) | ||
| self._exec( | ||
| [ | ||
| "kubeconfig", | ||
| "get", | ||
| self.cluster_name, | ||
| self.cluster_name if not config_yaml else config_yaml["name"], |
There was a problem hiding this comment.
Is it better to fill up self.cluster_name with config_yaml["name"] somewhere else during init?
There was a problem hiding this comment.
Will look for a better place :)
Schille
reviewed
Sep 30, 2024
I think we should make it mutually exclusive and require the name in the config file |
|
Any news about this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17