Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meetup Data via the ical feed #33

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

caseywatts
Copy link
Contributor

This is for #28

This isn't ready to be reviewed or merged, but I've got some proof of concept work done I wanted to share!

This depends on having a server grab the ics feed for us, to get around CORS.

  • For now I'm getting around it for development by using https://cors-anywhere.herokuapp.com/.
  • For production we should use our own cors proxy server. I imagine it could probably even be a serverless function so it's lightweight, cheap, and not much to maintain.

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A
  • Test B

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Notes / Details

@jphechter jphechter marked this pull request as draft September 19, 2022 14:20
@jphechter
Copy link
Member

marking as draft as this is still WIP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants