cmd/tracegen: Try to extract context from other params #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this pull request opened?
There are cases in which the traced interface does not accept a
context.Context
, but rather, uses the context from the passed down*http.Request
. These cases can also be traced with a little change in thetracegen
tool.What does this Pull request do?
This PR addresses the above-mentioned case.
Anything worth noting?
The code does not check if the
*Request
is actuallynet/http
or some other package (seeTODO
).Can you provide a minimal example?
Example
Given the source code
ifc.go
ingithub.com/Bo0mer/gentools/ifc
:running the tool produces the following file: