Add recipe-relative import SCMs #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #607 +/- ##
==========================================
+ Coverage 88.84% 88.85% +0.01%
==========================================
Files 48 48
Lines 15467 15474 +7
==========================================
+ Hits 13741 13750 +9
+ Misses 1726 1724 -2 ☔ View full report in Codecov by Sentry. |
jkloetzke
force-pushed
the
import-scm-root
branch
from
b786ebe to
285312b
Compare
The '__source' and 'recipe' string properties are created internally. They should not undergo any string substitution because it may alter their values.
The import SCM base directory is the project root directory. This is useless for recipes in layers because they don't know their location in the project. The new "recipeRelative" property can pivot the base directory to the one where the recipe is located.
jkloetzke
force-pushed
the
import-scm-root
branch
from
285312b to
4a6ef0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.