feat: optimize VariablePriorityQueue._get (#475)

BobTheBuidler · Dec 16, 2024 · 934210e · 934210e
1 parent 1b51365
commit 934210e
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/a_sync/primitives/queue.py b/a_sync/primitives/queue.py
@@ -707,8 +707,9 @@ def _get(self, heapify=heapq.heapify, heappop=heapq.heappop):
             >>> task = queue._get()
             >>> print(task)
         """
-        heapify(self._queue)
-        # take the job with the most waiters
+        # NOTE: Since waiter priorities can change, this might not return the job with the
+        #       most waiters if `self._queue` is not currently in order, but after calling `heappop`,
+        #       `self._queue` will always be in proper order for next call to `self._get`.
         return heappop(self._queue)
 
     def _get_key(self, *args, **kwargs) -> _smart._Key: