Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add the permission to release assets #160

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Aug 13, 2024

The release v1.7.0 failed due to the permission error.

https://github.com/Boeing/config-file-validator/actions/runs/10362649156/job/28684983356#step:6:284

+ github-assets-uploader -logtostderr -f ../validator-v1.7.0-linux-amd64.tar.gz -mediatype application/gzip -repo Boeing/config-file-validator -token *** -tag=v1.7.0 -releasename= -retry 3
W0813 02:34:38.260789    1654 main.go:48] Upload asset error, will retry in 4s: POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration []
W0813 02:34:42.775738    1654 main.go:48] Upload asset error, will retry in 9s: POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration []
E0813 02:34:52.242572    1654 err_exit.go:11] POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration []

The permission contents: write is required, but it was removed by f28a04d .

This pull request adds the permission to resolve the issue.

Test

I tested this pull request by creating a release at my fork and running the release workflow.
Then I confirmed releasing assets succeeded.

https://github.com/suzuki-shunsuke/config-file-validator/releases/tag/v1.7.1-0
https://github.com/suzuki-shunsuke/config-file-validator/actions/runs/10366714973/job/28696585997

The release v1.7.0 failed due to the permission error.

https://github.com/Boeing/config-file-validator/actions/runs/10362649156/job/28684983356#step:6:284

```
+ github-assets-uploader -logtostderr -f ../validator-v1.7.0-linux-amd64.tar.gz -mediatype application/gzip -repo Boeing/config-file-validator -token *** -tag=v1.7.0 -releasename= -retry 3
W0813 02:34:38.260789    1654 main.go:48] Upload asset error, will retry in 4s: POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration []
W0813 02:34:42.775738    1654 main.go:48] Upload asset error, will retry in 9s: POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration []
E0813 02:34:52.242572    1654 err_exit.go:11] POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration []
```

The permission `contents: write` is required, but it was removed by f28a04d#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34 .
So this commit adds the permission.
Copy link
Collaborator

@kehoecj kehoecj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for fixing this!

@kehoecj kehoecj merged commit 10a6def into Boeing:main Aug 13, 2024
10 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the ci-add-permission-to-release branch August 13, 2024 13:49
shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Aug 23, 2024
The release v1.7.0 failed due to the permission error.

https://github.com/Boeing/config-file-validator/actions/runs/10362649156/job/28684983356#step:6:284

```
+ github-assets-uploader -logtostderr -f ../validator-v1.7.0-linux-amd64.tar.gz -mediatype application/gzip -repo Boeing/config-file-validator -token *** -tag=v1.7.0 -releasename= -retry 3
W0813 02:34:38.260789    1654 main.go:48] Upload asset error, will retry in 4s: POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration []
W0813 02:34:42.775738    1654 main.go:48] Upload asset error, will retry in 9s: POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration []
E0813 02:34:52.242572    1654 err_exit.go:11] POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration []
```

The permission `contents: write` is required, but it was removed by Boeing@f28a04d#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34 .
So this commit adds the permission.
shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Oct 4, 2024
The release v1.7.0 failed due to the permission error.

https://github.com/Boeing/config-file-validator/actions/runs/10362649156/job/28684983356#step:6:284

```
+ github-assets-uploader -logtostderr -f ../validator-v1.7.0-linux-amd64.tar.gz -mediatype application/gzip -repo Boeing/config-file-validator -token *** -tag=v1.7.0 -releasename= -retry 3
W0813 02:34:38.260789    1654 main.go:48] Upload asset error, will retry in 4s: POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration []
W0813 02:34:42.775738    1654 main.go:48] Upload asset error, will retry in 9s: POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration []
E0813 02:34:52.242572    1654 err_exit.go:11] POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration []
```

The permission `contents: write` is required, but it was removed by Boeing@f28a04d#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34 .
So this commit adds the permission.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants