Display excludeable file types and validate #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kehoecj
added
hacktoberfest-accepted
|
@danielingegneri Thanks for the PR! Love the implementation. Looks like there is a goreportcard issue around the complexity in the |
…nts and flag usages; moved to caller, and made the flags a var block. Unfortunately not able to get complexity below 17.
|
Attempted to reduce complexity. Mostly by simplifying validation more. Also noticed the messages being printed on validation error, and the error being returned, were repeats. Suggest instead displaying the error text in thrown error. |
|
Is it preferred that I undo the additional logging changes made, and keep to minimum? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pull req, plz let me know if needs work. #170