Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to dynamically determine package version for PKGBUILD #186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timwehrle
Copy link
Contributor

Description:
This pull request resolves issue #176 by enhancing the PKGBUILD file to dynamically set the pkgver based on Git tags.

Changes:

  1. PKGBUILD:
    • Implemented a pkgver() function that dynamically retrieves the latest Git tag using git describe --tags.
    • The function uses sed 's/^v//;s/-.*//' to format the version string, ensuring it adheres to the pkgver format by:
      • Stripping the leading v from the tag (e.g., v1.7.1 becomes 1.7.1).
      • Removing any additional commit metadata (e.g., -3-ge168780).

@kehoecj kehoecj added hacktoberfest-accepted Valid PR Hacktoberfest PR hacktoberfest 🎃 Hacktoberfest 2024 waiting-on-maintainer-review PR is waiting to be reviewed and functionally tested by the maintainers labels Oct 21, 2024
@kehoecj kehoecj self-requested a review October 21, 2024 21:09
@kehoecj
Copy link
Collaborator

kehoecj commented Oct 21, 2024

@timwehrle Can you show me some output from testing this on Arch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest 🎃 Hacktoberfest 2024 hacktoberfest-accepted Valid PR Hacktoberfest PR waiting-on-maintainer-review PR is waiting to be reviewed and functionally tested by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants