Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
image
's#:size
property doesn't work well with something like'(#f 300)
, it tries to treat both of them as integers when they are not both#f
and that's the point.The problem happens in its internal
scale
function and I made it to scale eitherw
orh
following it original scale when one of them is#f
so it can properly fit the frame.BTW I don't know if it is fine for
'fill
mode...maybe it deserves further consideration.The problem can be tested with this piece of code.