list-view: avoid more work when keys don't change #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to existing discussion: - The removal loop does not trigger the inner conditional when the keys haven't changed anyway, because (member old-k new-keys) should always be true. - The call to change-children is redundant when the keys haven't changed because the list of children should also be the same. Thus we perform some work (looping, conditionals, and importantly a call to change-children) that is unnecessary: for performance, skip it. Close Bogdanp#57 Best-viewed-with: --ignore-space-change
|
Thanks! |
|
Nice improvement, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to existing discussion:
Thus we perform some work (looping, conditionals, and importantly a call to change-children) that is unnecessary: for performance, skip it.
Close #57
Best-viewed-with: --ignore-space-change