Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/js sdk improvement #69

Merged
merged 20 commits into from
Jul 31, 2024
Merged

Feat/js sdk improvement #69

merged 20 commits into from
Jul 31, 2024

Conversation

dr497
Copy link
Contributor

@dr497 dr497 commented May 17, 2024 •
edited
Loading

This PR aims to improve the developer experience of the SNS SDK, currently it covers:

  • Better error types
  • Faster retrieval of tokenized domain owner
  • Improve tree shake-ability
  • Remove useless key derivation of constant PDAs
  • Improve return type of instruction bindings

If you are reading this and have some improvement requests please comment below

dr497 and others added 20 commits May 17, 2024 12:39
@dr497
js: improve errors
9a0925c
@dr497
js: add retrieveNftOwnerV2
c0a6b4e
@dr497
fix: add missing custom error
61f2077
@letehaha @dr497
feat: Make record_v2 and utils tree-shakeable
fb6dcac
@dr497
js: harcode central state key to avoid derivation
db39fd6
@dr497
lint
28c66d2
@dr497
js: improve getProgramAccounts & handle error retrieveNftOwnerV2
60d6401
@letehaha @dr497
feat: Tree-shaking for bunch of modules
aae48f1 
- twitter/
- resolve/
- record/
- bindings/
- instructions/
@dr497
js: improve bindings return types
c93754e
@dr497
js: split nft bindings
57c35d2
@dr497
feat: add IPNS record
725f1a9
@dr497
js: adapt resolve to follow sns-ip-5
a970d2f
@dr497
chore: npm publish
d82f1ce
@dr497
Merge branch 'main' into feat/js-sdk-improvement
5442971
@dr497
js: fix tests
7ccda1b
@dr497
js: fix duplicate rollup config field
ba68fbc
@dr497
fix: remove sideEffects
45ef79a 
Creates issues with `buffer` in certain runtimes e.g cloudflare worker runtime
@dr497
chore: npm publish
90511ac
@dr497
feat: allow subs as
a5cf633
@dr497
chore: npm publish
94b18f4
@dr497 dr497 marked this pull request as ready for review July 31, 2024 09:56
@dr497 dr497 merged commit 5c341a6 into main Jul 31, 2024
3 of 4 checks passed
@dr497 dr497 deleted the feat/js-sdk-improvement branch July 31, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dr497 @letehaha