refactor: improvements to usage and browser compat #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any Buffer polyfill should be bundled by consumers instead, so we don't unnecessarily increase bundle sizes if they already have a Buffer impl.
This can be polyfilled on any JS platforms missing BigInt support.
This removes unnecessary callbacks for synchronous consumers. Since it is optional, existing code will continue to work fine.
This allows users to shrink bundle sizes by marking them as externals. I would prefer to do away with these entirely to shrink the library, but I've only opted to do this much for now.
retrixe
force-pushed
the
refactor/modernise
branch
from
ec74b09 to
3bc4443
Compare
retrixe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered several possible improvements while using this library in a React Native application, which I've decided to upstream (read commit messages for information).
This library is missing support for the newer anonymous NBT in 1.20.2+ which I just worked around on my side like so: https://github.com/retrixe/EnderChat/blob/809ff691c0fa39e8def7e831aa3d2d3184e0950d/src/minecraft/utils.ts#L182 I don't have the energy to work on it properly myself, so proper support is not part of this PR.
Side notes: