Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIRPA Optimisations and Bath Construction #122

Merged
merged 35 commits into from
Aug 11, 2023
Merged

RIRPA Optimisations and Bath Construction #122

merged 35 commits into from
Aug 11, 2023

Conversation

cjcscott
Copy link
Contributor

@cjcscott cjcscott commented Aug 8, 2023

This PR adds various updates to the RIRPA functionality within Vayesta. The three major components of this are:

  • Added support for RIRPA calculations to be performed with negative CDERI components.
  • Added new class specialised to performing efficient restricted, dRPA calculations. This is implemented using the existing numerical integration framework, and should correspond to a factor of ~2 speedup to the limiting steps of the computation.
  • Added new bath construction based on the RPA dd moment, as used in the mRPA paper.

These all have various tests and examples added. I also fixed a small bug in the optimisation of the quadrature spacing, where the search bounds were set unnecessarily tightly in some situations, which may result in an improved grid compared to previously. For practical calculations the difference in final results is tiny though (eg. as used in mRPA tests).

Things left to do:

  • Add RIRPA test on solids/graphene.

…egative CDERI contributions in RIRPA calculations.
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (583b949) 0.00% compared to head (0bd140a) 0.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #122    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files         139     142     +3     
  Lines       18645   18927   +282     
=======================================
- Misses      18645   18927   +282     
Files Changed Coverage Δ
vayesta/core/bath/__init__.py 0.00% <0.00%> (ø)
vayesta/core/bath/rpa.py 0.00% <0.00%> (ø)
vayesta/core/eris.py 0.00% <0.00%> (ø)
vayesta/core/helper.py 0.00% <ø> (ø)
vayesta/core/qemb/corrfunc.py 0.00% <0.00%> (ø)
vayesta/core/qemb/fragment.py 0.00% <0.00%> (ø)
vayesta/core/qemb/qemb.py 0.00% <0.00%> (ø)
vayesta/core/screening/screening_moment.py 0.00% <0.00%> (ø)
vayesta/rpa/rirpa/NI_eval.py 0.00% <0.00%> (ø)
vayesta/rpa/rirpa/RIRPA.py 0.00% <0.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghb24
Copy link
Contributor

ghb24 commented Aug 9, 2023

Is the example for a single k-point? It might be worth putting that explicitly, just to make it clear to users how to extend this further for reproduction of paper results.

@ghb24
Copy link
Contributor

ghb24 commented Aug 9, 2023

Also, I know that this PR may not be the right place, but should we have an example of cRPA screening with active space 'fragments', just to show off this functionality?

@cjcscott
Copy link
Contributor Author

I had gone for a single kpoint for the sake of keeping the examples fast, but I've changed it now to instead run with a minimal basis and (221) kpoints. I've also added an example running a CAS calculation on benzene with bare and screened interactions, just to show this off!

@cjcscott cjcscott merged commit dac7332 into master Aug 11, 2023
7 checks passed
@cjcscott cjcscott deleted the rpa_bath branch August 11, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants