-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RIRPA Optimisations and Bath Construction #122
Conversation
…egative CDERI contributions in RIRPA calculations.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #122 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 139 142 +3
Lines 18645 18927 +282
=======================================
- Misses 18645 18927 +282
☔ View full report in Codecov by Sentry. |
Is the example for a single k-point? It might be worth putting that explicitly, just to make it clear to users how to extend this further for reproduction of paper results. |
Also, I know that this PR may not be the right place, but should we have an example of cRPA screening with active space 'fragments', just to show off this functionality? |
I had gone for a single kpoint for the sake of keeping the examples fast, but I've changed it now to instead run with a minimal basis and (221) kpoints. I've also added an example running a CAS calculation on benzene with bare and screened interactions, just to show this off! |
This PR adds various updates to the RIRPA functionality within Vayesta. The three major components of this are:
These all have various tests and examples added. I also fixed a small bug in the optimisation of the quadrature spacing, where the search bounds were set unnecessarily tightly in some situations, which may result in an improved grid compared to previously. For practical calculations the difference in final results is tiny though (eg. as used in mRPA tests).
Things left to do: