Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeCov Fix Attempt #123

Merged
merged 1 commit into from
Aug 11, 2023
Merged

CodeCov Fix Attempt #123

merged 1 commit into from
Aug 11, 2023

Conversation

cjcscott
Copy link
Contributor

@cjcscott cjcscott commented Aug 11, 2023

This attempts to install Vayesta in editable mode within the github CI. This should hopefully fix the codecov (no guarantees) since we seem to actually be encountering a bug with coverage.py itself; for more info see nedbat/coveragepy#1034 or https://stackoverflow.com/questions/72986258/pytest-cov-showing-no-coverage.

It seems like the issue is that since we're installing not in editable mode, we're not technically running the /vayesta repository we specify we want coverage for and so no activity is traced. With any luck being in editable mode fixes this, otherwise I'll investigate something else.

Looking at the coverage bot this started after merging #97 and moving from setup.py to pyproject.toml, so I guess that may have changed this behaviour?

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +72.05% 🎉

Comparison is base (583b949) 0.00% compared to head (ca5a30f) 72.05%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #123       +/-   ##
===========================================
+ Coverage    0.00%   72.05%   +72.05%     
===========================================
  Files         139      139               
  Lines       18645    18645               
  Branches        0     2979     +2979     
===========================================
+ Hits            0    13435    +13435     
+ Misses      18645     4467    -14178     
- Partials        0      743      +743     

see 131 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cjcscott cjcscott merged commit bf7cbc7 into master Aug 11, 2023
7 checks passed
@cjcscott cjcscott deleted the codecov_fix branch August 11, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant