Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to install Vayesta in editable mode within the github CI. This should hopefully fix the codecov (no guarantees) since we seem to actually be encountering a bug with
coverage.py
itself; for more info see nedbat/coveragepy#1034 or https://stackoverflow.com/questions/72986258/pytest-cov-showing-no-coverage.It seems like the issue is that since we're installing not in editable mode, we're not technically running the
/vayesta
repository we specify we want coverage for and so no activity is traced. With any luck being in editable mode fixes this, otherwise I'll investigate something else.Looking at the coverage bot this started after merging #97 and moving from
setup.py
topyproject.toml
, so I guess that may have changed this behaviour?