Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov limit on coverage reduction. #124

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Add codecov limit on coverage reduction. #124

merged 1 commit into from
Aug 14, 2023

Conversation

cjcscott
Copy link
Contributor

This adds an additional codecov target which should fail if a PR reduces test coverage by more than 0.5%. This is arbitrarily configurable, but this seemed like a level of reduction which should allow large PRs with partial test coverage while prompting consideration if tests are totally absent.

This follows on from #123 , which fixed an issue with coverage calculation introduced in #97 that would've been caught by a check like this.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bf7cbc7) 72.52% compared to head (ddbc189) 72.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   72.52%   72.52%           
=======================================
  Files         142      142           
  Lines       19088    19088           
  Branches     3056     3056           
=======================================
  Hits        13844    13844           
  Misses       4479     4479           
  Partials      765      765           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghb24 ghb24 merged commit 57aae22 into master Aug 14, 2023
7 checks passed
@ghb24 ghb24 deleted the codecov_lim branch August 14, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants