Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k-space TDA #9

Merged
merged 69 commits into from
Aug 22, 2023
Merged

k-space TDA #9

merged 69 commits into from
Aug 22, 2023

Conversation

obackhouse
Copy link
Contributor

@obackhouse obackhouse commented Aug 1, 2023

Implements k-space TDA.

This PR also changes exactly what is outputed by qsGW. The gf attribute of a qsGW calculation is now the self-consistent Green's function in a larger space than the physical space, the size of which is dictated by nmom_max as in other methods. The quasiparticle energies which previously were stored in this Green's function can be recovered with the qsgw.qp_energy property. This property applies for all momentGW methods, and for other solvers it simply selects the best overlapping poles of the Green's function with each MO.

To-do:

  • Compression
    • Not the same as supercell!
  • Fock loop
  • Self-consistency
    • evGW
    • qsGW
      • Need to check this more thoroughly though
    • scGW
  • Parallelism
  • Interpolation
  • Finite-size q=0, G=0 correction: Should be extra simple for TDA

@obackhouse
Copy link
Contributor Author

obackhouse commented Aug 18, 2023

The SRG-qsGW test is still failing on zombie, but on my local machine it agrees with the CI... so i've set it to that value for now

@obackhouse
Copy link
Contributor Author

Interpolation is now added, but the theory should be discussed - it's definitely not true interpolation and there are a few asterisks, and it's yet to be tested for non-toy systems in more than 1D.

@obackhouse
Copy link
Contributor Author

The weird qsGW implementation matches the supercell just fine, I'm considering compression to be done even though it doesn't match the supercell as I can see how it would break the k-point symmetry.

@obackhouse
Copy link
Contributor Author

I've made sure compression is off by default for solids, it should really be benchmarked to work out whether or not it's properly implemented. Same goes for interpolation. Since these are not core features I'm going to merge this.

@ghb24
Copy link
Contributor

ghb24 commented Aug 22, 2023

Sounds good to me. I'm keen to check the quality of the interpolation for more complicated (3D) systems and compression though. Obviously, FSC will need to be looked at more carefully, as well as the small issue of checking D<3 systems...?

@obackhouse
Copy link
Contributor Author

Yeah, got all of that in mind

@obackhouse obackhouse merged commit 659bbc3 into main Aug 22, 2023
1 check passed
@obackhouse obackhouse deleted the pbc branch August 22, 2023 12:04
obackhouse added a commit to obackhouse/momentGW that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants