-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k-space TDA #9
k-space TDA #9
Conversation
The SRG-qsGW test is still failing on zombie, but on my local machine it agrees with the CI... so i've set it to that value for now |
Interpolation is now added, but the theory should be discussed - it's definitely not true interpolation and there are a few asterisks, and it's yet to be tested for non-toy systems in more than 1D. |
The weird qsGW implementation matches the supercell just fine, I'm considering compression to be done even though it doesn't match the supercell as I can see how it would break the k-point symmetry. |
I've made sure compression is off by default for solids, it should really be benchmarked to work out whether or not it's properly implemented. Same goes for interpolation. Since these are not core features I'm going to merge this. |
Sounds good to me. I'm keen to check the quality of the interpolation for more complicated (3D) systems and compression though. Obviously, FSC will need to be looked at more carefully, as well as the small issue of checking D<3 systems...? |
Yeah, got all of that in mind |
k-space TDA
Implements k-space TDA.
This PR also changes exactly what is outputed by qsGW. The
gf
attribute of a qsGW calculation is now the self-consistent Green's function in a larger space than the physical space, the size of which is dictated bynmom_max
as in other methods. The quasiparticle energies which previously were stored in this Green's function can be recovered with theqsgw.qp_energy
property. This property applies for allmomentGW
methods, and for other solvers it simply selects the best overlapping poles of the Green's function with each MO.To-do: